Skip to content

chore(deps): upgrade Vite+ to 1.7.0 - #4758

Open
james-elicx wants to merge 2 commits into
mainfrom
chore/vite-plus-1.7-tsrs
Open

james-elicx wants to merge 2 commits into
mainfrom
chore/vite-plus-1.7-tsrs

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Upgrades Vite+ to 1.7.0. vp lint and vp check now run type-aware lint rules and type checking with tsrs, the Rust port of TypeScript 7, instead of oxlint-tsgolint (announcement). The release also brings Oxlint 1.94.0, Oxfmt 0.79.0, Vite 8.3.8 and Rolldown 1.2.19.

  • Lint config is unchanged. The lint script drops OXLINT_TSGOLINT_CHECKER_SCHEDULING=sorted: only tsgolint read it, and neither Oxlint 1.94 nor tsrs does.
  • Oxfmt 0.79 adds parentheses around the instantiation expression in the dynamic() error boundary's extends clause (formatting only).
  • The pnpm minimumReleaseAge gate was bypassed for this install only (--config.minimum-release-age=0), with no workspace config change. The only locked packages younger than 24h are vite-plus@1.7.0, @voidzero-dev/vite-plus-core@8.3.8000 and the @voidzero-dev/vite-plus-* platform binaries; tsrs, Oxlint, Oxfmt and everything else they pull in are older.

Lint results

Same results as tsgolint on this repo. pnpm run check passes: 0 lint or type errors in 1858 files.

To compare the two backends I ran both through the same vp lint (same Oxlint 1.94, same config) and switched only OXLINT_TSGOLINT_PATH:

  • Project config: 0 diagnostics on both. --report-unused-disable-directives gives the same 61 entries on both.
  • A scratch file with planted errors gave byte-identical output on both: TS2322, TS2801, switch-exhaustiveness-check, restrict-template-expressions and no-misused-promises.
  • With all 61 type-aware rules turned on from the CLI (about 47.5k diagnostics), 47,466 were identical. 10 differ only in how long type names are truncated in the message. 2 prefer-readonly-parameter-types hits in it.each([...] as const) callbacks are reported by tsgolint only. That rule is not enabled here.

Performance

pnpm run lint, medians of 6 interleaved runs on an M-series Mac (shared machine). Peak memory is summed across the whole process tree.

wall CPU (user+sys) peak memory
main (Oxlint 1.91 + tsgolint 7.0.2005) 5.50s 18.6s 4.41 GB
this PR (Oxlint 1.94 + tsrs) 3.96s 8.8s 2.49 GB

pnpm run check takes 5.8-6.1s instead of 7.6-8.2s, and its peak memory drops from about 5.8 GB to 2.6 GB.

tests/fixtures/app-basic, main vs this PR, alternating runs:

main this PR
vp build (median of 8) 10.45s 10.06s
vp dev cold start to first / 200 (median of 12) 5.30s 4.84s
↳ until the dev server listens 1.62s 0.85s
↳ first request 3.71s 3.96s

Testing

  • pnpm run check
  • vp test run tests/vite-command-contract.test.ts tests/pages-router.test.ts tests/app-router-production-build.test.ts (599 passed)

Vite+ 1.7.0 runs type-aware linting and type checking with tsrs (the Rust
port of TypeScript 7) instead of oxlint-tsgolint. It also brings Oxlint
1.94.0, Oxfmt 0.79.0, Vite 8.3.8 and Rolldown 1.2.19.

The lint script no longer sets OXLINT_TSGOLINT_CHECKER_SCHEDULING: only
tsgolint read it. Oxfmt 0.79 parenthesizes the instantiation expression in
the dynamic() error boundary's extends clause.
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues
Please review exact head 4e770ef859941e2b697602ebde641d6694146bcc without modifying or pushing the branch. Report all actionable findings within your 8-minute time limit.

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@4758

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@4758

@vinext/types

npm i https://pkg.pr.new/@vinext/types@4758

vinext

npm i https://pkg.pr.new/vinext@4758

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@4758

commit: af42cbe

Six e2e fixtures have their own package.json outside the pnpm workspace, so
`vp run vinext#build` there sees a one-package workspace. Vite+ 1.5 ran
nothing and exited 0; since 1.6 an unknown package fails the run. Run the
build from the repo root instead.
@ask-bonk

ask-bonk Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues
Please review exact head af42cbe850a6148b8cb59c3028afa654b9f47443 without modifying or pushing the branch. Report all actionable findings within your 8-minute time limit.

@ask-bonk

ask-bonk Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared af42cbe against base 027d6d2 using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 1 regressed · 5 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 152.5 KB 152.5 KB ⚫ 0.0%
Client entry size (gzip) vinext 140.8 KB 140.8 KB ⚫ 0.0%
Dev server cold start vinext 2.29 s 2.33 s 🔴 +1.5%
Dev server cold start (large Pages Router app) vinext 18.95 s 18.72 s ⚫ -1.3%
Production build time vinext 2.73 s 2.65 s 🟢 -2.8%
RSC entry closure size (gzip) vinext 143.0 KB 143.0 KB ⚫ -0.0%
Server bundle size (gzip) vinext 250.9 KB 250.9 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-assets-cache preview production
static-assets-pages preview production
static-assets-pages-i18n preview production
static-export preview production
web preview production

@james-elicx
james-elicx marked this pull request as ready for review November 17, 2026 17:56

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — A clean toolchain upgrade with no findings. The e2e build commands now run from the right directories, and the dependency pins are exact.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

No issues found.


🔒 Security: ✅ LGTM

No issues found. minimumReleaseAge is unchanged in the workspace config.


📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

No issues found.

  • playwright.config.ts: Each subshell cd depth matches its fixture's cwd, so the relative paths that follow still resolve.
  • package.json: Dropping the environment variable only tsgolint read is consistent with the switch to tsrs.
  • Catalog pins: The pnpm-workspace.yaml pins are exact.
  • dynamic.ts: The change is formatting only.

⚡ Performance: ✅ LGTM

No issues found.


📝 Documentation: ✅ LGTM

No issues found.


Reviewed commit: af42cbe8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant