Repository navigation
build(deps): bump next from 16.2.7 to 16.4.5 in /benchmarks/nextjs - #4763
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [next](https://github.com/vercel/next.js) from 16.2.7 to 16.4.5. - [Release notes](https://github.com/vercel/next.js/releases) - [Commits](vercel/next.js@v16.2.7...v16.4.5) --- updated-dependencies: - dependency-name: next dependency-version: 16.4.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
There was a problem hiding this comment.
💬 Approved with comments — Safe one-line dependency bump in a benchmark app; the only note is an INFO about the benchmark's Next.js version now differing from the workspace-wide 16.2.7 pin.
Findings: 1 info (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 info
The bump is mechanically safe. One INFO note about version skew against the rest of the repo.
Recommendation: 💬 Optional Nits
- [INFO] The benchmark's Next.js version (16.4.5) now differs from the workspace-wide pin (16.2.7) (
benchmarks/nextjs/package.json:10)
View full review
benchmarks/nextjs/package.json:10 — version skew (INFO)
The benchmark compares vinext against real Next.js. After this bump the Next.js side runs 16.4.5. The rest of the repo stays on 16.2.7: the workspace catalog (pnpm-workspace.yaml, next and @next/mdx) and the create-next-app@16.2.7 steps in CI. Any build or dev performance change between those Next.js versions will move the benchmark numbers on its own, without any change in vinext. That is fine if the benchmark is meant to track the latest Next.js release. If the two sides are meant to match, bump the catalog and CI pins as well, here or in a follow-up.
There are no other issues. benchmarks/nextjs is installed on its own with npm install, has no lockfile, and tests/performance-benchmarks.test.ts does not pin next.
✅ All other checks passed
📝 Documentation: ✅ LGTM
No documentation changes are needed for this dependency bump.
Reviewed commit: 9ba5342f
| }, | ||
| "dependencies": { | ||
| "next": "16.2.7", | ||
| "next": "16.4.5", |
There was a problem hiding this comment.
ℹ️ INFO · Code Quality
The benchmark's Next.js version (16.4.5) now differs from the workspace-wide pin (16.2.7)
The benchmark app now runs Next.js 16.4.5, but the workspace catalog in pnpm-workspace.yaml and the create-next-app@16.2.7 CI steps still use 16.2.7. Any performance change between those Next.js versions will shift the benchmark numbers without any change in vinext. If the versions are meant to match, bump the catalog and CI pins too. If the benchmark is meant to track the latest release, this is fine as is.
Performance benchmarksCompared 3 improved · 1 regressed · 7 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Bumps next from 16.2.7 to 16.4.5.
Release notes
Sourced from next's releases.
... (truncated)
Commits
4e5335av16.4.5809be72[lts-active] Strip internal middleware cookie headers from edge responses (#282)2842833[lts-active] Fix stale compressed framing for forwarded fetch responses (#281)6596840[lts-active] [use cache] Fix cache key when binary args are used (#280)18eeffb[lts-active] Fix shared shell poisoning from request-supplied placeholder par...e66e656[lts-active] [next/image] Fix false-positive AVIF/HEIC detection (#278)d605874[lts-active] Fixunstable_cacheleaking cold'use cache'fills across roo...80c96ed[lts-active] Fix outer'use cache'entries reused across root param values ...b175f52v16.4.4ba4a4c1[lts-active] Use fast-jwt instead of jsonwebtoken (#100885)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.