Fix featured activities filters (malformed component markup) - #3657
Merged
Merged
Conversation
The online calendar view closed a section with a stray </div>, so the browser re-nested the DOM and Livewire could not morph the server response into the page. Filter requests returned correct data that was never rendered. Also move language-code normalisation onto the Event model so cards stop printing raw keys such as base.languages.eng. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
livewire/online-calendar.blade.php: a stray</div>closed<section>, leaving the component without valid nestingEventasdisplay_languages/normalizeLanguageCode, so cards no longer printbase.languages.engOnlineCalendarinstead of a duplicate private copyRoot cause
Filters were reaching the server and returning correct data. Verified live: after changing the month, the Livewire response contained
Showing 199 of 209while the DOM still showedShowing 209 of 209, andwire:snapshotnever advanced pastall.The cause is invalid HTML in the component view:
The browser re-nests this into a different tree than the server rendered, so Livewire's morph cannot match nodes and silently leaves the DOM untouched. Pagination still worked because it navigates via URL rather than morphing.
This explains why removing the duplicate Livewire script and Alpine v2 did not fix filtering: those were real problems, but this one was underneath them.
Test plan
/featured-activitiesbase.languages.*Made with Cursor