Repository navigation
Verify solar calculations and replace Objective-C with offline Swift - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Objective-C solar calculator with a shared offline Swift engine verified against independent USNO, Astronomy Engine and JPL reference data. Sunrise, sunset, twilight and photographic bands now use real crossings within the selected location's civil day, including polar and DST transitions.
The simulator timeline was checked for ordinary and polar locations. Widget data and extension packaging are verified; a home-screen widget visual check remains manual. Calculation conventions, baseline results and reproduction commands are in
docs/solar-reference.mdanddocs/solar-verification.md.