Repository navigation
Conversation
On very small viewports the DriveView media options pill used width: max-content, preventing it from shrinking and causing horizontal overflow. The TimeDisplay control bar also used fixed 40px controls that overflowed 320px viewports. - Media.jsx: use maxWidth: 100% instead of width: max-content - TimeDisplay: compact controls (32px) and smaller duration font under 420px; apply missing iconButton class to pause button
|
Welcome to connect! Make sure to:
deployed preview: https://768.connect-d5y.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760.
On very small viewports (320px), the DriveView media options pill used
width: max-content, which prevented it from shrinking and caused horizontal overflow. The TimeDisplay control bar's fixed 40px buttons and min-widths also overflowed narrow screens.Changes:
src/components/DriveView/Media.jsx: replacewidth: max-contentwithmaxWidth: 100%so the pill keeps its shape but can shrink.src/components/TimeDisplay/index.jsx: under 420px viewports, compact the icon buttons to 32px, reduce the time-box min-width to 32px, shrink the duration font to 13px with no wrapping. Also apply the previously missingiconButtonclass to the pause button.Verification: all 92 vitest tests pass, oxlint clean (0 warnings).