Repository navigation
feat: breakage-suite.yml — one report, and the REL1 check of a release PR - #105
Merged
Merged
Conversation
Replaces breakage.yml, whose cells each rewrote the PR comment with the results present at that moment and found it by the bot's id. The suite runs its matrix internally, each cell writing its result as a file; one report job writes one table (summary, one comment per group found by a marker, the breakage-<group> artifact). On a release PR it compares the stable column with the run on the base commit: a downstream release broken by a non-breaking number fails the job (REL1); no baseline or missing cells too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…actionlint clean Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a release Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #104 (it reuses
scripts/release/versions.jl); GitHub retargets it tomainonce #104 is merged.Why. In
breakage.yml, every cell of the matrix runs its owncommentjob, which rewrites the PR comment with the artifacts present at that moment: twelve concurrent writers, the last one may post an incomplete table. The comment is found by thegithub-actionsbot id, so it may overwrite another bot comment. Nothing is produced outside a PR, so there is no baseline to tell whether a failure comes from the PR.What.
breakage-suite.ymltakes the list of downstream packages (targets: name, owner,testordoc) and runs the matrix itself; each cell writes its result as a TOML file (status, tested ref, resolved version). Onereportjob (scripts/breakage/report.jl) writes the table to the job summary, to one PR comment pergroup(found by<!-- ct-breakage:<group> -->), and to thebreakage-<group>artifact.Release check (
REL1). A downstream failure never fails the run by itself: a breaking change is expected to break. On a release PR (the version changes), the report downloads the artifact of the run on the base commit (callers run the suite on push tomainand by hand), and compares the stable column: a package ✅ on the base and ❌ with the PR is broken by the release, so a non-breaking number fails the job; one already ❌ on the base is reported and says nothing. No baseline, or cells without result, also fail a release PR. With the job a required check, auto-merge cannot merge an inconsistent number.breakage.ymlstays, marked replaced, until every caller has moved (next PRs, in the packages).Checks:
scripts/breakage/test/runtests.jl→ 19 tests pass (verdict cases and written files); YAML parsed and everyrun:step passesbash -n; markdownlint (GEN2 configuration) → 0 issues. Not run end to end: thebreakjob and the baseline lookup are exercised by the first caller (CTBase).🤖 Generated with Claude Code