Repository navigation
Retry failed Index webhook deliveries - #432
Open
Hades32sBot wants to merge 1 commit into
Open
Hades32sBot wants to merge 1 commit into
Hades32sBot wants to merge 1 commit into
Conversation
Webhook uploads were single-shot: a non-2xx response or network error was recorded in the run history and dropped. Retry in-memory on transient failures — network errors/timeouts, 408, 429, and 5xx — with 1s/2s/5s backoff. Other 4xx and signing errors still fail immediately, and the test event stays single-shot so the settings UI gets instant feedback. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendTestEventstays single-shot so the settings UI gets instant feedback.retryableflag toIndexWebhookRunResultand anisRetryableStatuspredicate, covered by a new unit test.Note: this is deliberately in-memory only — it covers brief connectivity blips but not a dead endpoint or killed app process. A persisted retry queue (in the style of
MemfaultChunkQueue) could be a follow-up if wanted.Test plan
IndexWebhookRetryTestcovers the retryable-status predicate and backoff boundsFAILEDin run historycc @Hades32