Repository navigation
chore: Completely remove executedFeeAmount from API #3232
Description
Background
Once all executed fees are in the same token (surplus token), we can show following in the API:
- executedFee = executedFee + executedFeeAmount
- executedFeeAmount = 0 for ALL orders
as there are no clients that are interested in executedFeeAmount solely, and also, this field is only kept for legacy orders.
This effectively means we can remove executedFeeAmount from API.
Acceptance criteria
There is only ONE fee in the API that represents the total fee that was taken for execution of an order, and it's called executedFee.
Activity
sunce86 commentedon Jan 10, 2025
We should also consider completely removing
executedSellAmountBeforeFeesas I believe frontend is using onlyexecutedSellAmountfor these legacy orders.github-actions commentedon Mar 12, 2025
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.
MartinquaXD commentedon May 6, 2025
Blocked by #2963