Repository navigation
Conversation
…s as lists Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeyrb
marked this pull request as ready for review
October 8, 2026 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this when trying to make sure Supernotify worked well with Pyscript.
It has its own
notifyaction now, which is much richer than the plain vanillanotify.send_messagestyle to be easier to use from the actions UI. So a more complicated services.yaml, though other integrations might similarly be pushing what the configflow UI can do.Problem
pyscript.generate_stubsgets the signature wrong for services whoseservices.yamluses sections ormultipleselectors.additional_fieldsandadvanced_fields, but a section can have any name. Any other section becomes a bogus untyped parameter, and the fields inside it are dropped.multiple: true. Atext,selectorentityselector withmultiple: truetakes a list, but is annotated as a single value, so passing a list is reported as a type error.For example, a service with a
multimediasection and a multiple text field currently generates:Change
fieldsand noselector, whatever its name.multiple: trueis annotated aslist[...]of its usual type.The same service now generates:
Testing
Added
test_stubs_flatten_named_sections_and_multiple, which fails on master and passes with this change. The existing stub tests still pass.