Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @danielaparker - This is a smaller cbor_view for master that supersedes the cbor_view branch. It's not radically different, just (with the benefit of hindsight) the minimal zero-copy checked items "core" that doesn't sacrifice performance.
It is about half the lines of code, and purely additive: one new header and one new
cbor_errcvalue. Object code is ~20% smaller, and traversal is slightly faster. Tests and a fuzzer are also here.walker,wire_cursorand other features of the cbor_view branch could be added later, but I see them as much lower priority.I would be grateful for any comments you might have.