Skip to content

QAP - Use local contrast from new contrast & texture on scene referred. - #22338

Open
TurboGit wants to merge 1 commit into
masterfrom
po/rework-qap-new-contrastntexture
Open

TurboGit wants to merge 1 commit into
masterfrom
po/rework-qap-new-contrastntexture

Conversation

@TurboGit

@TurboGit TurboGit commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

The QAP scene referred module group now use the new contrast & texture module instead of the old local contrast.

The code has been indented for readability. The only change in this PR is the last line:

From:

AM("bilat/detail"); \

To:

    if(is_scene_referred)                          \
      AM("contrastntexture/local contrast");       \
    else                                           \
      AM("bilat/detail");                          \

Referenced issue

No issue.

Checklist

  • I have read CONTRIBUTING.md and the
    coding style.
  • I don't have merged master into the topic branch.
  • The pull request is one logical change, and every commit compiles on its
    own.
  • I ran the relevant tests: unit tests, src/tests/integration/ where the
    pixelpipe is touched, or darktable-cli as a headless smoke test.
  • New user-visible strings use _(), new preferences are registered in
    data/darktableconfig.xml.in.
  • A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues. Not needed as using a new module.

Test instructions

Switch from scene referred to display referred in the module group.

AI assistance

None.

@TurboGit TurboGit added this to the 5.8 milestone Sep 19, 2026
@TurboGit TurboGit added priority: low core features work as expected, only secondary/optional features don't feature: redesign current features to rewrite scope: UI user interface and interactions labels Sep 19, 2026
@TurboGit
TurboGit force-pushed the po/rework-qap-new-contrastntexture branch 2 times, most recently from 419589a to 689e675 Compare September 19, 2026 15:54
@TurboGit TurboGit changed the title Use local contrast from new contrast & texture on scene referred. QAP - Use local contrast from new contrast & texture on scene referred. Sep 19, 2026
@TurboGit
TurboGit force-pushed the po/rework-qap-new-contrastntexture branch from 689e675 to c0d7faa Compare September 19, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: redesign current features to rewrite priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant