Skip to content

Cache compiled OpenCL kernels at two locations - #22349

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:split_opencl_fast_kernels
Sep 21, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:split_opencl_fast_kernels

Conversation

@jenshannoschwalm

@jenshannoschwalm jenshannoschwalm commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • We now use two directories for the cached kernels thus a fast mode toggle won't enforce a recompilation of all kernels.

  • We read the "opencl_fast" conf just once while initializing the OpenCL subsystem

  • For debugging and integration testing we always use the non-fast kernels.

  • I have read CONTRIBUTING.md and the coding style.

  • I have not merged master into the topic branch.

  • The pull request is one logical change, and every commit compiles on its own.

  • I ran the relevant tests: unit tests, src/tests/integration/ where the pixelpipe is touched, or darktable-cli as a headless smoke test.

  • New user-visible strings use _(), new preferences are registered in data/darktableconfig.xml.in.

  • A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.

@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Sep 21, 2026
@jenshannoschwalm jenshannoschwalm added feature: enhancement current features to improve scope: codebase making darktable source code easier to manage OpenCL Related to darktable OpenCL code scope: debugging labels Sep 21, 2026
- We now use two directories for the cached kernels thus a fast mode toggle won't enforce
  a recompilation of all kernels.
- We read the "opencl_fast" conf just once while initializing the OpenCL subsystem
- For debugging and integration testing we always use the non-fast kernels.
@jenshannoschwalm
jenshannoschwalm force-pushed the split_opencl_fast_kernels branch from 8164082 to d0f0b3d Compare September 21, 2026 11:11

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit 0f375f3 into darktable-org:master Sep 21, 2026
10 of 12 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the split_opencl_fast_kernels branch September 21, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: enhancement current features to improve OpenCL Related to darktable OpenCL code scope: codebase making darktable source code easier to manage scope: debugging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants