Skip to content

Add queueing for orcid claims instead of direct http call - #275

Merged
richardhallett merged 5 commits into
masterfrom
queue_orcid_claims
Sep 8, 2026
Merged

richardhallett merged 5 commits into
masterfrom
queue_orcid_claims

Conversation

@richardhallett

Copy link
Copy Markdown
Contributor

Purpose

To avoid pressure on the http endpoint, we will add to volpino queue for processing.

Approach

Similiar to existing code as to not diverge too much.

Open Questions and Pre-Merge TODOs

N/A

Learning

The way we use "workers" is quite different to the activejob, I keep forgetting this and it makes it very reliant on SQS, to-do: replacement.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

This in similiar fashion to existing code sends a message onto volpino
queue for pickup.
@richardhallett
richardhallett requested a review from a team September 8, 2026 12:43
Accidentally added back in, shouldnt exist
- Various fixes to stub the send message
- Change test not to check for marrema result as not doing this anymore
@richardhallett
richardhallett merged commit 318c91a into master Sep 8, 2026
3 checks passed
@richardhallett
richardhallett deleted the queue_orcid_claims branch September 8, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants