Repository navigation
Add queueing for orcid claims instead of direct http call - #275
Merged
Merged
Conversation
This in similiar fashion to existing code sends a message onto volpino queue for pickup.
1 of 3 tasks
wendelfabianchinsamy
approved these changes
Sep 8, 2026
Accidentally added back in, shouldnt exist
- Various fixes to stub the send message - Change test not to check for marrema result as not doing this anymore
jrhoads
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To avoid pressure on the http endpoint, we will add to volpino queue for processing.
Approach
Similiar to existing code as to not diverge too much.
Open Questions and Pre-Merge TODOs
N/A
Learning
The way we use "workers" is quite different to the activejob, I keep forgetting this and it makes it very reliant on SQS, to-do: replacement.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: