Repository navigation
Conversation
Ford544
force-pushed
the
inline-assertion-config
branch
from
November 18, 2026 10:35
2f5ab93 to
6b97cbe
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1295
Current behavior:
Inline assertions (assertion actions generated automatically from the assertions block in action config) always run with the default project and default assertion dataset. Action-level "schema" and "project" overrides do not apply to them.
Example:
workflow_settings.yaml:
some_action.sqlx:
Result: the table action itself runs in specific_project.specific_dataset, while the uniqueKey assertion runs in default_project.dataform_assertions.
As such there is currently no way to override the default project and dataset for inline assertions.
Proposed change
Make action-level database override apply to inline assertions (assumption: users typically will want to keep data and assertions results in the same project).
In case a different database for assertions is needed, also allow to set the database field inside the assertions block. This then applies only to inline assertions in that action and takes precedence over action-level database override.
For datasets, defaultAssertionDataset should still take precedence over the action-level dataset override (assumption: it is usually preferred to keep data and assertion results in different datasets).
If defaultAssertionDataset is unset, fall back to the action-level dataset if set, then to defaultDataset.
Also allow setting the dataset inside the assertions block. This then applies only to inline assertions in that action and takes precedence over action-level dataset override.
Order of precedence for inline assertions:
project: assertions-level override > action-level override > defaultProject
dataset: assertions-level override > defaultAssertionDataset > action-level override > defaultDataset
This resolves the issue #1295 by applying action-level project overrides to inline assertions and grants users a fine control over which datasets assertions write to.
Breaking change: this can affect the behavior of existing projects under certain edge conditions, such as: