Repository navigation
fix(json): retain node identities with custom entity names - #163
Merged
datnguye merged 1 commit intoOct 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
===========================================
+ Coverage 99.90% 100.00% +0.09%
===========================================
Files 45 45
Lines 2163 2166 +3
===========================================
+ Hits 2161 2166 +5
+ Misses 2 0 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
LGTM thanks @dajiaohuang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #159
Description
Resolve relationship display names to emitted node IDs at the JSON target boundary, before collecting FK flags or formatting edges. This preserves short/custom node names without dangling edge IDs or missing FK column flags, and leaves shared input relationships unchanged.
Validated with public
DbtErd(artifacts_dir=..., target="json", entity_name_format="table").get_erd()on entirely authored tiny manifest v12/catalog v1 artifacts: both edge endpoints resolve to emitted nodes,customer_idis flagged, and the JSON schema passes. The regression fails on the base and passes with this change.Checks: complete unit suite 575 passed (7 existing Click deprecation warnings); changed-file Ruff lint/format and
git diff --checkpass. Python 3.13 on Windows. No live dbt, database, Cloud API, or downstream editor acceptance testing. CI results are not claimed.Checklist