Conversation
Signed-off-by: aryan kolapkar <aryan.kolapkar@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ab1f27788
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert torch_available, ("Unable to pre-compile ops because torch is not available in the build environment. " | ||
| "Install torch first, then run pip install --no-build-isolation deepspeed.") |
There was a problem hiding this comment.
Preserve
DS_BUILD_OPS in the recovery command
When the documented one-shot invocation DS_BUILD_OPS=1 pip install deepspeed reaches this error because build isolation hides PyTorch, following the suggested command installs DeepSpeed with the Linux default of DS_BUILD_OPS=0. That succeeds but skips the precompiled ops the user requested; the recovery command should retain DS_BUILD_OPS=1 (along with --no-build-isolation).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
Summary
Fixes #8480.
Test
pre-commit run --files setup.py docs/_tutorials/advanced-install.md--no-build-isolation