Skip to content

docs: fix precompiled ops install command - #8484

Open
arubittu wants to merge 1 commit into
deepspeedai:masterfrom
arubittu:docs/8480-precompile-build-isolation
Open

arubittu wants to merge 1 commit into
deepspeedai:masterfrom
arubittu:docs/8480-precompile-build-isolation

Conversation

@arubittu

Copy link
Copy Markdown

Summary

  • disable pip build isolation in the documented precompiled-op install commands
  • explain how to expose an existing PyTorch install to the build

Fixes #8480.

Test

  • pre-commit run --files setup.py docs/_tutorials/advanced-install.md
  • reproduced the setup error in a clean build environment without PyTorch and confirmed it points to --no-build-isolation

Signed-off-by: aryan kolapkar <aryan.kolapkar@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ab1f27788

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread setup.py
Comment on lines +158 to +159
assert torch_available, ("Unable to pre-compile ops because torch is not available in the build environment. "
"Install torch first, then run pip install --no-build-isolation deepspeed.")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve DS_BUILD_OPS in the recovery command

When the documented one-shot invocation DS_BUILD_OPS=1 pip install deepspeed reaches this error because build isolation hides PyTorch, following the suggested command installs DeepSpeed with the Linux default of DS_BUILD_OPS=0. That succeeds but skips the precompiled ops the user requested; the recovery command should retain DS_BUILD_OPS=1 (along with --no-build-isolation).

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex address that feedback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't install in Python 3.14.6 with GCC

1 participant