Skip to content

Fix NuGet compatibility checks for versioned platform targets - #16869

Open
brettfo wants to merge 1 commit into
dependabot:mainfrom
brettfo:dev/brettfo/nuget-tfm-compat
Open

brettfo wants to merge 1 commit into
dependabot:mainfrom
brettfo:dev/brettfo/nuget-tfm-compat

Conversation

@brettfo

@brettfo brettfo commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

What are you trying to accomplish?

Fix false package incompatibility reports for versioned platform TFMs.

Anything you want to highlight for special attention from reviewers?

Fall back to NuGet's compatibility provider while preserving existing compatibility exceptions.

How will you know you've accomplished your goal?

Package-backed regression tests reproduced three failures before the fix. All 177 targeted tests now pass:

dotnet test nuget\helpers\lib\NuGetUpdater\NuGetUpdater.Core.Test\NuGetUpdater.Core.Test.csproj --no-restore --filter 'FullyQualifiedName~Analyze|FullyQualifiedName~FrameworkChecker' --verbosity quiet --nologo -clp:ErrorsOnly

Full suite not run.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 05fa2c73-d931-4f82-8e78-5fb95d345f36
@brettfo
brettfo requested a review from a team as a code owner November 9, 2026 22:21
Copilot AI balanced review requested due to automatic review settings November 9, 2026 22:21
@github-actions github-actions Bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dotnet:nuget NuGet packages via nuget or dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants