Skip to content

feat(analytics): send the redirect target of the login page - #609

Merged
yhabib merged 2 commits into
mainfrom
feat/login-redirect-target-analytics
Nov 16, 2026
Merged

yhabib merged 2 commits into
mainfrom
feat/login-redirect-target-analytics

Conversation

@yhabib

@yhabib yhabib commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Motivation

From 2 to 15 Nov, 2,465 of 8,662 login page visits (28%) never signed in. Plausible cannot tell which page these visitors tried to open. requireIdentity sends them to /?redirect=<path> before the tracker starts, and removeUrlParams drops the query.

Changes

  • Added addRedirectTarget, which sets a redirect_target property on each event on / that has a redirect query.
  • Grouped proposal paths as /voting/proposals/:id and reported paths with any other form as other, so no ID reaches Plausible.
  • Applied it in transformRequest before removeUrlParams.
  • Added tests for the helper and for the pageview, login_success, and outbound click on the login page.

Add a redirect_target property to each event on / that has a redirect
query, so Plausible shows which page a signed-out visitor tried to open.
@yhabib
yhabib requested a review from a team as a code owner November 16, 2026 06:52
Copilot AI balanced review requested due to automatic review settings November 16, 2026 06:52
@zeropath-ai

zeropath-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ No security or compliance issues detected. Reviewed everything up to b9c9b75.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► src/governance-app-frontend/src/features/analytics/transformRequest.ts
    + Adds static path handling and addRedirectTarget implementation to compute redirect_target for login redirects
Enhancement ► src/governance-app-frontend/src/features/analytics/service.ts
    + Integrates addRedirectTarget into payload cleaning before grouping proposal pages
Enhancement ► src/governance-app-frontend/src/features/analytics/transformRequest.spec.ts
    + Updates tests to cover addRedirectTarget behavior and integration with payload transformation
Enhancement ► src/governance-app-frontend/src/features/analytics/service.spec.ts
    + Adds test for redirect_target on login page events

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

📊 Build Bundle Stats

The latest build generated the following assets:

dist/index.html                                          22.14 kB │ gzip:   5.67 kB
dist/assets/index-B18cPvr8.css                          154.72 kB │ gzip:  24.92 kB
dist/assets/icpLedger-0lrGTnuw.js                         0.23 kB │ gzip:   0.21 kB
dist/assets/icpIndex-BqcADx4V.js                          0.26 kB │ gzip:   0.22 kB
dist/assets/useNowInSeconds-duFlb1xv.js                   0.44 kB │ gzip:   0.31 kB
dist/assets/webhid-D0yio6wG.js                            0.53 kB │ gzip:   0.32 kB
dist/assets/advancedFeatures-DwKHR_Rv.js                  0.53 kB │ gzip:   0.27 kB
dist/assets/useTvlValue-CE44OXno.js                       0.60 kB │ gzip:   0.41 kB
dist/assets/webVitals-DZ8StOa8.js                         0.63 kB │ gzip:   0.46 kB
dist/assets/nnsDapp-D0XWfpZz.js                           0.68 kB │ gzip:   0.25 kB
dist/assets/DeviceActionDetail-DI3Ksr2L.js                0.75 kB │ gzip:   0.37 kB
dist/assets/SkeletonPageHeader-B84myOTD.js                0.76 kB │ gzip:   0.47 kB
dist/assets/PageHeader-AvJeSwTP.js                        0.77 kB │ gzip:   0.45 kB
dist/assets/SkeletonStatCard-D12VKXkF.js                  0.78 kB │ gzip:   0.49 kB
dist/assets/CertifiedBadge-BcV1LLbQ.js                    0.81 kB │ gzip:   0.49 kB
dist/assets/Separator-C5dkl7BW.js                         0.83 kB │ gzip:   0.50 kB
dist/assets/useGovernanceAppCanister-DXPmnXSX.js          0.88 kB │ gzip:   0.54 kB
dist/assets/useForecastPeriod-DkOnl4cL.js                 1.01 kB │ gzip:   0.61 kB
dist/assets/utils-tXT1QHWh.js                             1.02 kB │ gzip:   0.59 kB
dist/assets/useIcpIndex-Rj8cgoCn.js                       1.09 kB │ gzip:   0.64 kB
dist/assets/useSubaccountsMetadata-3ERjcDVq.js            1.09 kB │ gzip:   0.62 kB
dist/assets/numbers-BUvGIWZU.js                           1.15 kB │ gzip:   0.57 kB
dist/assets/rolldown-runtime-DAXXjFlN.js                  1.26 kB │ gzip:   0.70 kB
dist/assets/useHardwareWalletsMetadata-DrQ7BsX6.js        1.39 kB │ gzip:   0.68 kB
dist/assets/addressBook-BZfI7dzI.js                       1.66 kB │ gzip:   0.91 kB
dist/assets/events-DlpmuKIm.js                            1.67 kB │ gzip:   0.86 kB
dist/assets/SkeletonListRows-rSzAvtxV.js                  1.70 kB │ gzip:   0.54 kB
dist/assets/useCommandPaletteSettings-BUeo_yko.js         1.73 kB │ gzip:   0.86 kB
dist/assets/routeLoaders-Dh-evQNF.js                      1.77 kB │ gzip:   0.80 kB
dist/assets/useLedgerNeuronCall-BANKnu5n.js               1.89 kB │ gzip:   1.04 kB
dist/assets/errors-C_oENL0S.js                            1.95 kB │ gzip:   0.97 kB
dist/assets/AnimatedNumber-CasnHcbo.js                    1.98 kB │ gzip:   1.13 kB
dist/assets/useIcpIndexTransactionsPolling-DFHn4EIQ.js    2.17 kB │ gzip:   1.15 kB
dist/assets/useTheme-B1U58yF0.js                          2.87 kB │ gzip:   1.41 kB
dist/assets/governance-B_NtCLJ3.js                        2.98 kB │ gzip:   1.15 kB
dist/assets/ToggleGroup-OL7UmOLj.js                       3.09 kB │ gzip:   1.41 kB
dist/assets/useClaimPendingDeviceStakes-B234cxte.js       3.12 kB │ gzip:   1.43 kB
dist/assets/SkeletonText-BCvrZivW.js                      3.68 kB │ gzip:   1.28 kB
dist/assets/SensitiveValue-D_n9qcfw.js                    3.88 kB │ gzip:   1.49 kB
dist/assets/useAccounts-DZ0ZcF-R.js                       4.80 kB │ gzip:   2.13 kB
dist/assets/Chart-B_fFyA2L.js                             5.78 kB │ gzip:   2.67 kB
dist/assets/vendor-tslib-BHbJFxAR.js                      6.23 kB │ gzip:   1.88 kB
dist/assets/tickers-CRFzQpIV.js                           6.55 kB │ gzip:   2.69 kB
dist/assets/Spinner-Da3_nZWD.js                           7.14 kB │ gzip:   2.48 kB
dist/assets/QueryStates-rit_DoxO.js                       7.78 kB │ gzip:   2.84 kB
dist/assets/TopicFollowingAccordion-Bkbn0XU0.js           8.55 kB │ gzip:   3.41 kB
dist/assets/routes-DPoxzpqy.js                            8.97 kB │ gzip:   3.08 kB
dist/assets/ledgerIdentity-Gu7zza-c.js                   10.21 kB │ gzip:   3.71 kB
dist/assets/MutationDialog-CH_hfUnh.js                   11.54 kB │ gzip:   4.04 kB
dist/assets/addressBook-B2Uf3sc3.js                      14.65 kB │ gzip:   4.15 kB
dist/assets/AmountInput-Dv5Twuw6.js                      16.90 kB │ gzip:   6.75 kB
dist/assets/spamFilter-CLqQY2Rt.js                       19.45 kB │ gzip:   7.43 kB
dist/assets/HideBalancesToggle-BM73xbMz.js               19.90 kB │ gzip:   7.68 kB
dist/assets/_auth-DrbtQVvH.js                            22.61 kB │ gzip:   8.37 kB
dist/assets/accounts-Tn-P4ZUK.js                         25.07 kB │ gzip:   8.76 kB
dist/assets/vendor-buffer-EX-AqChq.js                    26.95 kB │ gzip:   8.18 kB
dist/assets/SendICPButton-BgOAoY0q.js                    37.07 kB │ gzip:  13.52 kB
dist/assets/_id-BAw7-y4z.js                              40.16 kB │ gzip:  13.69 kB
dist/assets/dashboard-9b4ZHhLc.js                        52.20 kB │ gzip:  16.96 kB
dist/assets/settings-OD1edHEK.js                         54.45 kB │ gzip:  15.45 kB
dist/assets/voting-CjbAX3lx.js                           61.90 kB │ gzip:  19.39 kB
dist/assets/vendor-md-B1mF9qhV.js                        73.28 kB │ gzip:  19.98 kB
dist/assets/index-C1Ulj7L_.js                            80.68 kB │ gzip:  24.57 kB
dist/assets/Skeleton-DNP_TkIN.js                         93.16 kB │ gzip:  31.47 kB
dist/assets/neurons-rBFElAbj.js                          99.79 kB │ gzip:  29.83 kB
dist/assets/DisburseModal-osggDX35.js                   103.25 kB │ gzip:  30.19 kB
dist/assets/vendor-tanstack-qTnVYEJ2.js                 120.01 kB │ gzip:  39.21 kB
dist/assets/vendor-jsqr-CjiBYtfG.js                     129.98 kB │ gzip:  47.50 kB
dist/assets/vendor-core-react-BVwfugT6.js               189.81 kB │ gzip:  59.76 kB
dist/assets/vendor-recharts-DVQc_pqN.js                 297.43 kB │ gzip:  80.52 kB
dist/assets/vendor-ledger-OJ5MzzT7.js                   397.24 kB │ gzip:  97.02 kB
dist/assets/vendor-icp-BupkQmAW.js                      469.08 kB │ gzip: 118.24 kB
dist/assets/vendor-libs-fYBU1ZGS.js                     587.80 kB │ gzip: 189.81 kB

🚦 Startup JS budget

✅ The startup JS is 478,642 bytes gzip. The budget is 480,000.

27 startup files
File Gzip bytes
assets/vendor-libs-fYBU1ZGS.js 188,189
assets/vendor-icp-BupkQmAW.js 115,363
assets/vendor-core-react-BVwfugT6.js 59,068
assets/vendor-tanstack-qTnVYEJ2.js 38,762
assets/Skeleton-DNP_TkIN.js 31,205
assets/index-C1Ulj7L_.js 24,404
assets/addressBook-B2Uf3sc3.js 4,117
assets/Spinner-Da3_nZWD.js 2,477
assets/useAccounts-DZ0ZcF-R.js 2,117
assets/vendor-tslib-BHbJFxAR.js 1,884
assets/useTheme-B1U58yF0.js 1,414
assets/SkeletonText-BCvrZivW.js 1,274
assets/governance-B_NtCLJ3.js 1,155
assets/errors-C_oENL0S.js 979
assets/routeLoaders-Dh-evQNF.js 798
assets/rolldown-runtime-DAXXjFlN.js 704
assets/useHardwareWalletsMetadata-DrQ7BsX6.js 685
assets/useSubaccountsMetadata-3ERjcDVq.js 622
assets/utils-tXT1QHWh.js 597
assets/Separator-C5dkl7BW.js 502
assets/SkeletonStatCard-D12VKXkF.js 491
assets/SkeletonPageHeader-B84myOTD.js 476
assets/webhid-D0yio6wG.js 328
assets/useNowInSeconds-duFlb1xv.js 318
assets/advancedFeatures-DwKHR_Rv.js 270
assets/icpIndex-BqcADx4V.js 229
assets/icpLedger-0lrGTnuw.js 214

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The redirect-target regex exposes alphabetic principal IDs in analytics because it accepts arbitrary lowercase and hyphenated path segments instead of restricting them to known static routes.

1 open issue
What changed in this PR

Adds redirect-target tracking to login-page analytics so Plausible can show which pages signed-out visitors intended to open.

Changes:

  • Adds redirect_target to login-page events, grouping proposal URLs and masking unsupported path forms.
  • Extracts the target before removing URL query parameters.
  • Adds helper tests and coverage for pageviews, login success, and outbound clicks.
File Description
src/​governance-app-frontend/​src/​features/​analytics/​transformRequest.ts Adds redirect-target extraction and path normalization.
src/​governance-app-frontend/​src/​features/​analytics/​transformRequest.spec.ts Tests target grouping, filtering, and property preservation.
src/​governance-app-frontend/​src/​features/​analytics/​service.ts Applies redirect tracking before URL cleanup.
src/​governance-app-frontend/​src/​features/​analytics/​service.spec.ts Tests redirect properties across login-page event types.

Review effort: Balanced

A path such as /accounts/<principal> has no digits, so the pattern
let a principal through. Report any path that is not an app page as
other.
Copilot AI balanced review requested due to automatic review settings November 16, 2026 06:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The redirect-target tracking change has no active review issues blocking approval.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@yhabib
yhabib added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 4a337a7 Nov 16, 2026
13 checks passed
@yhabib
yhabib deleted the feat/login-redirect-target-analytics branch November 16, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants