Skip to content

feat(backend): keep a daily ICP/USD and USD/fiat rate history - #610

Open
yhabib wants to merge 2 commits into
mainfrom
feat/daily-rate-history
Open

yhabib wants to merge 2 commits into
mainfrom
feat/daily-rate-history

Conversation

@yhabib

@yhabib yhabib commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The Reports page needs the ICP/USD rate and the fiat rate of each day since 1 January 2025, for the fiat columns and the Year summary. The backend keeps only 30 days of ICP/USD and the current fiat rates. The first fill costs about 690 ICP/USD calls at 500M cycles each (about 0.35T cycles), one time. Fiat pairs make no exchange calls, so they cost less.

Changes

  • Added a daily history in stable memory: the 00:00 UTC rate of each day for ICP/USD and for USD to each supported fiat currency.
  • Added fill_daily_history_gaps, which fetches the missing days, newest first, at start and every 6 hours. A run does nothing while another run is in progress.
  • Fetched the fiat rate of a day only 3 days after it starts, when the XRC forex rate of that day is final.
  • Added the list_daily_exchange_rates query. It takes a time range and an optional fiat symbol, and returns one entry for each day with a rate.
  • Added tests for the missing days, the range query, the retry of a failed day, and the unsupported symbol.

The year reports need the rate of each day since 1 January 2025.
The history keeps the 00:00 UTC rate of each day in stable memory.
A timer fills the missing days at start and every 6 hours.
@yhabib
yhabib requested a review from a team as a code owner November 16, 2026 06:54
Copilot AI balanced review requested due to automatic review settings November 16, 2026 06:54
@github-actions

Copy link
Copy Markdown

📊 Build Bundle Stats

The latest build generated the following assets:

dist/index.html                                          22.14 kB │ gzip:   5.66 kB
dist/assets/index-B18cPvr8.css                          154.72 kB │ gzip:  24.92 kB
dist/assets/icpLedger-BSJS1fFs.js                         0.23 kB │ gzip:   0.21 kB
dist/assets/icpIndex-BWeH4ZBg.js                          0.26 kB │ gzip:   0.23 kB
dist/assets/useNowInSeconds-yl17EOKh.js                   0.44 kB │ gzip:   0.31 kB
dist/assets/webhid-D0yio6wG.js                            0.53 kB │ gzip:   0.32 kB
dist/assets/advancedFeatures-CQV5Xv9q.js                  0.53 kB │ gzip:   0.27 kB
dist/assets/useTvlValue-CckyMzwX.js                       0.60 kB │ gzip:   0.41 kB
dist/assets/webVitals-UHm6qL-G.js                         0.63 kB │ gzip:   0.45 kB
dist/assets/nnsDapp-DI6UcAdt.js                           0.68 kB │ gzip:   0.25 kB
dist/assets/DeviceActionDetail-DI3Ksr2L.js                0.75 kB │ gzip:   0.37 kB
dist/assets/SkeletonPageHeader-DNy01FxX.js                0.76 kB │ gzip:   0.47 kB
dist/assets/PageHeader-AvJeSwTP.js                        0.77 kB │ gzip:   0.45 kB
dist/assets/SkeletonStatCard-CwbOWERx.js                  0.78 kB │ gzip:   0.48 kB
dist/assets/CertifiedBadge-CiRcwH3U.js                    0.81 kB │ gzip:   0.48 kB
dist/assets/Separator-BGjFcrkm.js                         0.83 kB │ gzip:   0.50 kB
dist/assets/useGovernanceAppCanister-DFhPseB9.js          0.88 kB │ gzip:   0.54 kB
dist/assets/useForecastPeriod-jaOAp5Op.js                 1.01 kB │ gzip:   0.60 kB
dist/assets/utils-D3S9D940.js                             1.02 kB │ gzip:   0.59 kB
dist/assets/useIcpIndex-DI09h5jX.js                       1.09 kB │ gzip:   0.64 kB
dist/assets/useSubaccountsMetadata-CASoy4TZ.js            1.09 kB │ gzip:   0.62 kB
dist/assets/numbers-BIJP4miH.js                           1.15 kB │ gzip:   0.57 kB
dist/assets/rolldown-runtime-DAXXjFlN.js                  1.26 kB │ gzip:   0.70 kB
dist/assets/useHardwareWalletsMetadata-8E437IEK.js        1.39 kB │ gzip:   0.68 kB
dist/assets/addressBook-BpyLeg6N.js                       1.66 kB │ gzip:   0.91 kB
dist/assets/events-BqVNhRur.js                            1.67 kB │ gzip:   0.86 kB
dist/assets/SkeletonListRows-FTIqZ04A.js                  1.70 kB │ gzip:   0.53 kB
dist/assets/useCommandPaletteSettings-RzcPROIK.js         1.73 kB │ gzip:   0.86 kB
dist/assets/routeLoaders-CWLRkI8x.js                      1.77 kB │ gzip:   0.79 kB
dist/assets/useLedgerNeuronCall-CLC1gWbO.js               1.89 kB │ gzip:   1.04 kB
dist/assets/errors-C_oENL0S.js                            1.95 kB │ gzip:   0.97 kB
dist/assets/AnimatedNumber-CDE8q8R3.js                    1.98 kB │ gzip:   1.13 kB
dist/assets/useIcpIndexTransactionsPolling-B-GRFwep.js    2.17 kB │ gzip:   1.15 kB
dist/assets/useTheme-9gN-YY1j.js                          2.87 kB │ gzip:   1.41 kB
dist/assets/governance-DE3-oIuA.js                        2.98 kB │ gzip:   1.15 kB
dist/assets/ToggleGroup-Cl8W0fwp.js                       3.09 kB │ gzip:   1.40 kB
dist/assets/useClaimPendingDeviceStakes-CxKj3yKP.js       3.12 kB │ gzip:   1.43 kB
dist/assets/SkeletonText-6LRdhd57.js                      3.68 kB │ gzip:   1.28 kB
dist/assets/SensitiveValue-C2Gl3CdH.js                    3.88 kB │ gzip:   1.49 kB
dist/assets/useAccounts-CEFyTAL0.js                       4.80 kB │ gzip:   2.13 kB
dist/assets/Chart-BGz6fpRZ.js                             5.78 kB │ gzip:   2.67 kB
dist/assets/vendor-tslib-BHbJFxAR.js                      6.23 kB │ gzip:   1.88 kB
dist/assets/tickers-Rw2qmUWU.js                           6.55 kB │ gzip:   2.69 kB
dist/assets/Spinner-B_Ae25CK.js                           7.14 kB │ gzip:   2.48 kB
dist/assets/QueryStates-Cn8Ih50X.js                       7.78 kB │ gzip:   2.84 kB
dist/assets/TopicFollowingAccordion-t8i66VJS.js           8.55 kB │ gzip:   3.41 kB
dist/assets/routes-Ba6CkCgJ.js                            8.97 kB │ gzip:   3.08 kB
dist/assets/ledgerIdentity-Gu7zza-c.js                   10.21 kB │ gzip:   3.71 kB
dist/assets/MutationDialog-C07zwoP9.js                   11.54 kB │ gzip:   4.04 kB
dist/assets/addressBook-BsHeduuB.js                      14.65 kB │ gzip:   4.15 kB
dist/assets/AmountInput-DMVcRDKJ.js                      16.90 kB │ gzip:   6.75 kB
dist/assets/spamFilter-6Je9cQDh.js                       19.45 kB │ gzip:   7.43 kB
dist/assets/HideBalancesToggle-CoLvGNJL.js               19.90 kB │ gzip:   7.68 kB
dist/assets/_auth-DkPs2yhS.js                            22.61 kB │ gzip:   8.36 kB
dist/assets/accounts-DUWEox1T.js                         25.07 kB │ gzip:   8.76 kB
dist/assets/vendor-buffer-EX-AqChq.js                    26.95 kB │ gzip:   8.18 kB
dist/assets/SendICPButton-7RjkuCVy.js                    37.07 kB │ gzip:  13.52 kB
dist/assets/_id-DBA21AmZ.js                              40.16 kB │ gzip:  13.69 kB
dist/assets/dashboard--EYE02QH.js                        52.20 kB │ gzip:  16.96 kB
dist/assets/settings-OJYiU94E.js                         54.45 kB │ gzip:  15.45 kB
dist/assets/voting-ClnTHvco.js                           61.90 kB │ gzip:  19.39 kB
dist/assets/vendor-md-B1mF9qhV.js                        73.28 kB │ gzip:  19.98 kB
dist/assets/index-D2gEt0Gg.js                            80.68 kB │ gzip:  24.59 kB
dist/assets/Skeleton-D0xxEhO0.js                         93.14 kB │ gzip:  31.43 kB
dist/assets/neurons-XlHyYzR9.js                          99.79 kB │ gzip:  29.83 kB
dist/assets/DisburseModal-anpo7ELe.js                   103.25 kB │ gzip:  30.19 kB
dist/assets/vendor-tanstack-qTnVYEJ2.js                 120.01 kB │ gzip:  39.21 kB
dist/assets/vendor-jsqr-CjiBYtfG.js                     129.98 kB │ gzip:  47.50 kB
dist/assets/vendor-core-react-BVwfugT6.js               189.81 kB │ gzip:  59.76 kB
dist/assets/vendor-recharts-DVQc_pqN.js                 297.43 kB │ gzip:  80.52 kB
dist/assets/vendor-ledger-OJ5MzzT7.js                   397.24 kB │ gzip:  97.02 kB
dist/assets/vendor-icp-BupkQmAW.js                      469.08 kB │ gzip: 118.24 kB
dist/assets/vendor-libs-fYBU1ZGS.js                     587.80 kB │ gzip: 189.81 kB

🚦 Startup JS budget

✅ The startup JS is 478,602 bytes gzip. The budget is 480,000.

27 startup files
File Gzip bytes
assets/vendor-libs-fYBU1ZGS.js 188,189
assets/vendor-icp-BupkQmAW.js 115,363
assets/vendor-core-react-BVwfugT6.js 59,068
assets/vendor-tanstack-qTnVYEJ2.js 38,762
assets/Skeleton-D0xxEhO0.js 31,160
assets/index-D2gEt0Gg.js 24,414
assets/addressBook-BsHeduuB.js 4,117
assets/Spinner-B_Ae25CK.js 2,477
assets/useAccounts-CEFyTAL0.js 2,117
assets/vendor-tslib-BHbJFxAR.js 1,884
assets/useTheme-9gN-YY1j.js 1,416
assets/SkeletonText-6LRdhd57.js 1,273
assets/governance-DE3-oIuA.js 1,155
assets/errors-C_oENL0S.js 979
assets/routeLoaders-CWLRkI8x.js 796
assets/rolldown-runtime-DAXXjFlN.js 704
assets/useHardwareWalletsMetadata-8E437IEK.js 685
assets/useSubaccountsMetadata-CASoy4TZ.js 624
assets/utils-D3S9D940.js 595
assets/Separator-BGjFcrkm.js 500
assets/SkeletonStatCard-CwbOWERx.js 488
assets/SkeletonPageHeader-DNy01FxX.js 474
assets/webhid-D0yio6wG.js 328
assets/useNowInSeconds-yl17EOKh.js 318
assets/advancedFeatures-CQV5Xv9q.js 271
assets/icpIndex-BWeH4ZBg.js 230
assets/icpLedger-BSJS1fFs.js 215

@zeropath-ai

zeropath-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ No security or compliance issues detected. Reviewed everything up to 2bc5fa1.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► src/governance-app-backend/backend.did
    Add daily exchange rate types and list daily exchange rates API
► src/governance-app-backend/src/exchange_rate.rs
    Introduce daily history support and list_daily_exchange_rates function
► src/governance-app-backend/src/exchange_rate/daily_history.rs
    Add daily history data structures and utilities for listing and missing rates
► src/governance-app-backend/src/lib.rs
    Expose list_daily_exchange_rates via API
► src/governance-app-backend/src/stable_memory.rs
    Add stable memory IDs for daily history storage
Refactor ► src/governance-app-backend/src/exchange_rate.rs
    Refactor to use new daily history module and types
► src/governance-app-backend/src/exchange_rate/tests.rs
    Update tests to incorporate daily history changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An older XRC rate is stored under the requested date and never refreshed, making report values depend on when the first fetch occurred.

1 open issue
What changed in this PR

Adds persistent daily exchange-rate history for the Reports page’s fiat columns and yearly summaries, covering dates from 1 January 2025.

Changes:

  • Stores daily ICP/USD and supported USD/fiat rates in stable memory.
  • Fills missing rates newest first at startup and every six hours, preventing overlapping runs.
  • Exposes a date-range query with optional fiat selection and adds coverage for queries, retries, and fill guarding.
File Description
src/​governance-app-backend/​src/​stable_memory.rs Allocates stable-memory IDs for daily histories.
src/​governance-app-backend/​src/​lib.rs Exposes the daily exchange-rate query.
src/​governance-app-backend/​src/​exchange_rate/​tests.rs Tests missing rates, range queries, retries, and validation.
src/​governance-app-backend/​src/​exchange_rate/​daily_history.rs Implements stable storage, range reads, and missing-rate detection.
src/​governance-app-backend/​src/​exchange_rate.rs Adds scheduled gap filling, overlap protection, and query handling.
src/​governance-app-backend/​backend.did Defines the public daily-rate query and its types.

Review effort: Balanced

The XRC updates a day's forex rates for up to 2 days, and it gives an
earlier day's rate while a day has none. The fill keeps the first rate
that it gets, so it now waits 3 days before it fetches a fiat rate.
Copilot AI balanced review requested due to automatic review settings November 16, 2026 07:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues block approval of the persistent daily exchange-rate history change.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants