Repository navigation
Conversation
Contributor
Author
|
Could a maintainer rerun test-fast (3.13)? The only failure was test_get_text_from_filing_with_no_body_tag, where filing.html() returned None for a Pear Tree Advisors filing. The six cash-flow regression cases passed locally. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
When a company reports operating cash flow separately for continuing and discontinued operations,
EntityFacts.get_concept("operating_cash_flow")could return the continuing-operations subtotal as the company-wide total. The lookup now returnsNonewhen it selects that subtotal and finds nonzero discontinued operating cash flow for the same reporting period and currency.Fixes #1987
Verification
0001628280-25-058405. The filing reports $127,000 from continuing operations and $5,000 from discontinued operations. The regression test uses those amounts and checks that the lookup returnsNone. A separate check using archived SEC Company Facts asserted that GE still returns its reported FY2023 total of $5.179 billion (10-K accession0000040545-24-000027).tests/issues/regression/test_issue_1987.pylinks the issue in its docstring. All six cases passed.changelog.d/1987.fixed.mdSIFCO FY2025 10-K · GE FY2023 10-K
AI assistance