Skip to content

fix: add app icon - #77

Merged
KaiVandivier merged 1 commit into
mainfrom
app-icon
Oct 7, 2026
Merged

KaiVandivier merged 1 commit into
mainfrom
app-icon

Conversation

@kabaros

@kabaros kabaros commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

added to AppHub as well

image

Comment thread i18n/en.pot
Comment on lines -120 to -124
msgid "{{label}}, {{count}} unread"
msgid_plural "{{label}}, {{count}} unread"
msgstr[0] "{{label}}, {{count}} unread"
msgstr[1] "{{label}}, {{count}} unread"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something happened here -- is this what Hendrik flagged? dhis2/app-platform#964 (can be addressed later)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct! Strings with count (which is a magical variable name apparently) are dropped due to that regression I found.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@KaiVandivier
KaiVandivier merged commit 38abecb into main Oct 7, 2026
5 checks passed
dhis2-bot added a commit that referenced this pull request Oct 7, 2026
## [1.13.2](v1.13.1...v1.13.2) (2026-10-07)

### Bug Fixes

* add app icon ([#77](#77)) ([38abecb](38abecb))
@dhis2-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants