refactor(pagination): rename Paginator getters to L13 names (task 2.15, part 1) - #53
Merged
Merged
Conversation
…5, part 1) Converge the app-facing Paginator accessors to the L13 surface (strict-mode: old getters removed -> method-not-found forces app/template conform): getCurrentPage -> currentPage getLastPage -> lastPage getFrom -> firstItem getTo -> lastItem getPerPage -> perPage getTotal -> total getItems -> items Update fork-internal Paginator callers: Presenter, the 3 bundled view templates, BelongsToMany::paginate hydration, and the Pagination tests. links() unchanged. The pagination Factory keeps its own getCurrentPage() (internal wiring), untouched here. Ratchet: pagination_getters 15 -> 10 (the 5 remaining are Factory getCurrentPage() calls in Query/Eloquent Builder). Baseline updated. Deferred to the Database-entangled window (task 2.5): removing the pagination Factory + Presenter/BootstrapPresenter and dropping the Paginator $factory ctor arg -- those rewire ->paginate() across Connection/Query\Builder/ Eloquent\Builder, so they ship with the Database work, not here. Tests: tests/Pagination green (40), Database builder/relation tests green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Base automatically changed from
migration/2.14-view-strict-mode
to
pre-release/4.2.94
September 16, 2026 03:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 2.15 (part 1) — Paginator getter rename
[fork]Konvergensi accessor Paginator yang dipakai template/controller app ke surface L13 (strict-mode: getter lama dihapus → method-not-found → memaksa app conform).
getCurrentPage()currentPage()getLastPage()lastPage()getFrom()firstItem()getTo()lastItem()getPerPage()perPage()getTotal()total()getItems()items()Caller fork-internal ikut diupdate:
Presenter, 3 view template bundled,BelongsToMany::paginatehydration, test Pagination.links()tetap. Factory pagination tetap punyagetCurrentPage()sendiri (wiring internal) — tak disentuh di sini.Ratchet:
pagination_getters15 → 10 (5 sisa = callgetCurrentPage()ke Factory di Query/Eloquent Builder). Baseline diupdate.⏭️ Ditunda ke window Database (task 2.5)
Membuang Factory pagination + Presenter/BootstrapPresenter dan drop arg
$factorydi ctor Paginator merewire->paginate()lintasConnection/Query\Builder/Eloquent\Builder— itu bagian kerja Database (XL), bukan di sini. Jadi PR ini sengaja = bagian getter (bernilai app-facing, bounded, low-risk).Verifikasi
phpunit tests/Pagination→ 40 hijau; Database builder + BelongsToMany relation tests hijau; lint bersih; DB-builder Factory-getter dipastikan tak tersentuh.Urutan
Stacked di atas #52 (stack: #45←#46←#48←#52←ini). Blocker (1.1) ✅.
🤖 Generated with Claude Code