Skip to content

Generate formatter defaults from the version catalog - #3045

Open
builtbyjuls wants to merge 2 commits into
diffplug:mainfrom
builtbyjuls:issue-2705-gjf-buildconfig
Open

Generate formatter defaults from the version catalog#3045
builtbyjuls wants to merge 2 commits into
diffplug:mainfrom
builtbyjuls:issue-2705-gjf-buildconfig

Conversation

@builtbyjuls

@builtbyjuls builtbyjuls commented Sep 8, 2026

Copy link
Copy Markdown

Closes #2705.

@Goooler

Goooler commented Sep 8, 2026

Copy link
Copy Markdown
Member

Needs to check the other versions as well, replace all related usages.

@builtbyjuls

Copy link
Copy Markdown
Author

Thanks. To confirm, should I generate constants for every catalog-backed formatter/runtime default in lib and replace their usages across lib and the plugins, while keeping compatibility thresholds and intentionally older compile pins hardcoded?

I found four catalog/default mismatches: Gson 2.14.0/2.13.2, Jackson YAML 2.20.1/2.14.1, Cleanthat 2.24/2.25, and Palantir 1.1.0/2.80.0. Including those would change or downgrade current defaults. Should this PR reconcile those too?

@Goooler

This comment was marked as outdated.

@Goooler

This comment was marked as outdated.

@builtbyjuls
builtbyjuls force-pushed the issue-2705-gjf-buildconfig branch from ae74a21 to c2449ef Compare September 10, 2026 22:46
@builtbyjuls builtbyjuls changed the title Generate the google-java-format default from the version catalog Generate formatter defaults from the version catalog Sep 10, 2026
@builtbyjuls

Copy link
Copy Markdown
Author

Thanks, @Goooler. I updated the PR to cover the full mandatory scope you outlined.

  • Generated package-private defaults for the catalog-backed formatter runtimes, including the 11 ready items.
  • Added the separate Palantir 2.80.0 runtime default while keeping its 1.1.0 compile-only pin.
  • Updated Cleanthat to 2.25, Gson to 2.14.0, and Jackson YAML to the shared Jackson 2.20.1 version.
  • Made both Gradle and Maven JSON Patch defaults follow JsonPatchStep.defaultVersion().
  • Kept compatibility thresholds, historical test versions, and intentional compile-only pins hardcoded.
  • Left the optional formatters and NPM/native/P2 items out of scope.
  • Added the requested Gson entry to CHANGES.md.

All affected formatter and plugin tests pass. The aggregate build encountered only an external Gradle download timeout and a parallel P2 lock collision; all three affected test methods passed when rerun alone. An independent post-change review also approved the implementation with no findings.

Updated commit: c2449efda

@Goooler
Goooler force-pushed the issue-2705-gjf-buildconfig branch from c2449ef to 8592c4b Compare September 11, 2026 03:45
@Goooler
Goooler force-pushed the issue-2705-gjf-buildconfig branch from 7c87ddd to e1edf8f Compare September 11, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use gradle-buildconfig-plugin to generate dependency versions

2 participants