Skip to content

Require Edit Data permission on Web Apps debugger routes - #1796

Merged
dannyroberts merged 2 commits into
masterfrom
dm/debugger-permissions
Sep 23, 2026
Merged

dannyroberts merged 2 commits into
masterfrom
dm/debugger-permissions

Conversation

@dannyroberts

Copy link
Copy Markdown
Member

Product Description

No user-facing change.

Technical Summary

Reads the permissions list from HQ's session_details response, which dimagi/commcare-hq#38173 adds, and has DebuggerController return 403 to users without edit_data.

Safety Assurance

Safety story

This only affects users without edit_data. A missing permissions field counts as no access.

Automated test coverage

DebuggerControllerTest covers both the permitted and denied cases. The session details parsing tests cover the new field.

QA Plan

Covered by automated tests.

Special deploy instructions

Deploy dimagi/commcare-hq#38173 first. Until HQ sends permissions, this change denies debugger access to every user.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.25%. Comparing base (cc028eb) to head (8173fb4).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1796      +/-   ##
============================================
+ Coverage     70.67%   72.25%   +1.58%     
- Complexity     2100     2149      +49     
============================================
  Files           260      261       +1     
  Lines          8132     8147      +15     
  Branches        796      797       +1     
============================================
+ Hits           5747     5887     +140     
+ Misses         2094     1968     -126     
- Partials        291      292       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dannyroberts
dannyroberts marked this pull request as ready for review September 23, 2026 20:57
@dannyroberts
dannyroberts merged commit 24383ac into master Sep 23, 2026
6 checks passed
@dannyroberts
dannyroberts deleted the dm/debugger-permissions branch September 23, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants