Repository navigation
Require Edit Data permission on Web Apps debugger routes - #1796
Merged
Merged
Conversation
gherceg
approved these changes
Sep 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1796 +/- ##
============================================
+ Coverage 70.67% 72.25% +1.58%
- Complexity 2100 2149 +49
============================================
Files 260 261 +1
Lines 8132 8147 +15
Branches 796 797 +1
============================================
+ Hits 5747 5887 +140
+ Misses 2094 1968 -126
- Partials 291 292 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
No user-facing change.
Technical Summary
Reads the
permissionslist from HQ'ssession_detailsresponse, which dimagi/commcare-hq#38173 adds, and hasDebuggerControllerreturn 403 to users withoutedit_data.Safety Assurance
Safety story
This only affects users without
edit_data. A missingpermissionsfield counts as no access.Automated test coverage
DebuggerControllerTestcovers both the permitted and denied cases. The session details parsing tests cover the new field.QA Plan
Covered by automated tests.
Special deploy instructions
Deploy dimagi/commcare-hq#38173 first. Until HQ sends
permissions, this change denies debugger access to every user.Rollback instructions
Review
🤖 Generated with Claude Code