Repository navigation
fix #23982 - [REG master] -g crashes link.exe on Windows because of empty S_ENVBLOCK - #23988
Merged
Merged
Conversation
… of empty S_ENVBLOCK remove record as it is also not produced by msvc or clang. It is created by the linker only.
thewilsonator
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove S_ENVBLOCK record as it is also not produced by msvc or clang. It is created by the linker only.
The record is corrupt because it is interpreted as list of strings terminated by an empty string. This is later grouped into key-value pairs, but that does not allow specifying an empty value string.
The same information is provided by the S_BUILDINFO record, that is also produced by clang (see https://codebrowser.dev/llvm/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp.html#715), but not msvc.