Skip to content

fix(deps): override immutable 4.3.9 in /templates - #11026

Closed
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/npm_and_yarn/templates/multi-7ea0977b71
Closed

dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/npm_and_yarn/templates/multi-7ea0977b71

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 6, 2026

Copy link
Copy Markdown
Contributor

Why

The original immutable 3.8.2 -> 3.8.3 bump addressed Dependabot alert #66, but it is no longer sufficient: alerts #118 (GHSA-v56q-mh7h-f735) and #120 (GHSA-xvcm-6775-5m9r) affect every Immutable release below 4.3.9.

browser-sync 3.0.4 and browser-sync-ui 3.0.4 both declare immutable: ^3, and there is no patched 3.x release for the newer advisories.

Change

  • Add scoped npm overrides that force only BrowserSync and its UI to Immutable 4.3.9, the smallest release patched for all three alerts.
  • Regenerate templates/package-lock.json through npm rather than editing it by hand.
  • Keep Sass and Sass Embedded on their supported Immutable 5.1.9 dependency line.
  • Merge the latest main; the PR diff remains limited to the template package manifest and lockfile, with no Bootstrap changes.

This crosses BrowserSync's declared Immutable major-version range, so the compatibility risk is non-zero. The scope is deliberately limited to the two BrowserSync consumers, whose used APIs (Map, List, OrderedSet, fromJS, is, and merge/get operations) remain available in 4.3.9. A live BrowserSync/UI startup smoke test exercises the Immutable-backed config path and confirms an HTTP response before clean shutdown.

Security result

Validation

  • npm test
  • npm run lint
  • npm run build
  • BrowserSync/UI Immutable config startup and HTTP smoke check
  • npm audit --registry=https://packagefeedproxy.microsoft.io/npm/

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps  and [immutable](https://github.com/immutable-js/immutable-js). These dependencies needed to be updated together.

Updates `immutable` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/immutable-js/immutable-js/releases)
- [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md)
- [Commits](immutable-js/immutable-js@v3.8.2...v3.8.3)

Updates `immutable` from 5.1.4 to 5.1.5
- [Release notes](https://github.com/immutable-js/immutable-js/releases)
- [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md)
- [Commits](immutable-js/immutable-js@v3.8.2...v3.8.3)

---
updated-dependencies:
- dependency-name: immutable
  dependency-version: 3.8.3
  dependency-type: indirect
- dependency-name: immutable
  dependency-version: 5.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 6, 2026
vicancy and others added 2 commits August 14, 2026 10:07
Force BrowserSync and its UI onto the first release patched for the current Immutable advisories while leaving Sass on its supported 5.x line.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@vicancy vicancy changed the title chore(deps): bump immutable in /templates fix(deps): override immutable 4.3.9 in /templates Aug 14, 2026
@vicancy

vicancy commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded by #11139, which brought Immutable 3.8.4 into main without crossing BrowserSync's declared major-version range.

The advisories have since been updated with a patched 3.x release: both GHSA-v56q-mh7h-f735 and GHSA-xvcm-6775-5m9r list 3.8.4 as fixed for the 3.x line. The corresponding repository alerts are now marked fixed. Current main resolves BrowserSync's Immutable to 3.8.4 and retains Sass/Sass Embedded on 5.1.9.

The description's earlier statement that no patched 3.x release exists is therefore no longer current. The forced 4.3.9 overrides are unnecessary for these fixes and would add avoidable compatibility risk.

@vicancy vicancy closed this Sep 18, 2026
auto-merge was automatically disabled September 18, 2026 06:38

Pull request was closed

@dependabot @github

dependabot Bot commented on behalf of github Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/templates/multi-7ea0977b71 branch September 18, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant