Search each file of a multi-targeted F# project once in Find All References and Rename

[xperiandri]

Description

Find All References and Rename on a symbol of a multi-targeted F# project did every piece of work once per target framework. Measured in the debugger on a solution with 135 project instances: a scope of two projects (the two instances of one .fsproj) grew to 86 instances of 26 project files after adding dependents, 1246 documents in all; the snapshots of all 86 were built one after another before the first search started; every file was type checked once per instance, and FCS never shares those checks between instances; Roslyn's window hides the duplicate results, so the user only sees the time. On top of that the "skip the files before the declaration" optimisation only applied in the instance owning the first DocumentId of the declaration, because Project.FindFSharpReferencesAsync compared document.Project = this by reference.

Change (SymbolHelpers.fs, WorkspaceExtensions.fs):

• getSymbolUsesInProjects keeps F# projects only (which also stops getFSharpOptionsForProject from being asked about a C# project in the external-symbol branch) and, with EnableFastFindReferencesAndRename on (the default), groups the instances of one project file. The instance searched in full is the one of the current document, else one in its dependency closure, else the first; the other instances only search files compiled solely there and files whose conditional compilation tests a define the two instances disagree on. Only that difference can make a shared file parse differently, so the #if expressions (ParsedInput.Trivia.ConditionalDirectives) are read for the idents they test rather than merely counted: an inactive #if DEBUG no longer forces a second search, and instances whose defines match skip their shared files outright, which also spares the checker the project builds those searches would force. Uses are reported once per range across the whole search, so a file two projects compile - the instances of one project file, or two project files sharing a source file - no longer reports each use twice.
• Searches start as soon as a project's snapshot is ready instead of after all snapshots; snapshots are built only for the transparent compiler (Document.FindFSharpReferencesAsync takes an FSharpProjectSnapshot voption and picks the FCS overload from it); one SemaphoreSlim(ProcessorCount) bounds the concurrent file checks across the whole search instead of per project.
• Project.FindFSharpReferencesAsync resolves the declaration document inside its own instance, so the compile-order skip works in every instance.
• The two dead arms of findSymbolUses (CurrentDocument/SignatureAndImplementation inside the | scope -> fallback) are gone; the outer match is exhaustive.

Behaviour change with the option off: every instance is still searched in full, but the concurrency bound now applies across the solution where the code used to run one project's documents sequentially and projects without a limit. Residual risk with the option on: an instance can resolve an overload differently without any #if (an extension member shadowed by a newer BCL intrinsic); the ranking covers the polyfill case within the current project's world, and turning the option off restores the full search.

Rename needs no change: getSymbolUsesInSolution now yields one DocumentId per file plus the instance-specific ones, and Roslyn merges the edits of linked documents.

Tests: MultiTargetFindReferencesTests loads one project as two instances (one without FOO and without the fourth file, one with both) through the new RoslynTestHelpers.CreateMultiTargetSolution and, starting from either instance, checks that Find All References reports the signature, the plain use, both uses in the #if FOO file, the use in the instance-only file and the use guarded by a define both instances share exactly once each, and that Rename gets every use once, each from an instance that compiles its file. The first commit (test helpers) is shared with #20462; the second moves the IFSharpFindUsagesContext stub into RoslynTestHelpers.

No timings are claimed: on the solution above the search scope goes from 86 instances to 26, plus the conditional and instance-only files of the other 60.

Checklist

• Test cases added

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

🤖 Generated with Claude Code

[github-actions]

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
`vsintegration/src`	docs/release-notes/.VisualStudio/18.vNext.md