[vs18.9] Disable unavailable OptProf data - #14925
Draft
AR-May wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e52f6743-7447-4fcb-817f-8f2498b9a5e0
AR-May
temporarily deployed
to
copilot-pat-pool
September 2, 2026 15:02 — with
GitHub Actions
Inactive
AR-May
temporarily deployed
to
copilot-pat-pool
September 2, 2026 15:02 — with
GitHub Actions
Inactive
AR-May
had a problem deploying
to
copilot-pat-pool
September 2, 2026 15:03 — with
GitHub Actions
Failure
AR-May
temporarily deployed
to
copilot-pat-pool
September 2, 2026 15:06 — with
GitHub Actions
Inactive
AR-May
temporarily deployed
to
copilot-pat-pool
September 2, 2026 15:07 — with
GitHub Actions
Inactive
AR-May
temporarily deployed
to
copilot-pat-pool
September 2, 2026 15:07 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The pipeline-only changes are consistent with existing enableOptProf gating patterns in the same templates and align with the stated goal of preventing OptProf-related build failures on this servicing branch.
Pull request overview
Disables OptProf data collection by default on vs18.9 to avoid failures caused by unavailable optimization data / assembly version mismatches during the OptProf collection run, while keeping the existing SkipApplyOptimizationData=true behavior when collection is disabled.
Changes:
- Set
enableOptProfdefault tofalsefor this branch and document the rationale in the pipeline parameters. - Gate publishing of the
MicroBuildOutputsartifact onenableOptProf, since it’s only produced when the OptProf bootstrapper runs. - Move the
MicroBuild/Outputstaging-path check into theenableOptProfbranch of the artifact layout validation; bumpVersionPrefixto18.9.15.
File summaries
| File | Description |
|---|---|
| eng/Versions.props | Bumps VersionPrefix to 18.9.15 for the servicing branch. |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Conditions MicroBuildOutputs publication and OptProf-only staging-path validation on enableOptProf. |
| .vsts-dotnet.yml | Defaults enableOptProf to false and documents why OptProf is disabled on this branch. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
AR-May
marked this pull request as draft
September 2, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #14903 (vs18.6), #14902 (vs18.0) and #14909 (vs16.11).
Changes Made
enableOptProfto default tofalse.SkipApplyOptimizationData=truewhen OptProf collection is disabled, avoiding the unavailable-data restore.MicroBuildOutputsartifact publish onenableOptProf, since it is only produced when the OptProf bootstrapper runs.MicroBuild/Outputstaging path into theenableOptProfbranch of the artifact-layout check for the same reason.VersionPrefixto18.9.15.Notes