Skip to content

[vs18.9] Disable unavailable OptProf data - #14925

Draft
AR-May wants to merge 1 commit into
dotnet:vs18.9from
AR-May:disable-optprof-vs18.9
Draft

[vs18.9] Disable unavailable OptProf data#14925
AR-May wants to merge 1 commit into
dotnet:vs18.9from
AR-May:disable-optprof-vs18.9

Conversation

@AR-May

@AR-May AR-May commented Sep 2, 2026

Copy link
Copy Markdown
Member

Follows #14903 (vs18.6), #14902 (vs18.0) and #14909 (vs16.11).

Changes Made

  • Changed enableOptProf to default to false.
  • Kept the existing behavior that sets SkipApplyOptimizationData=true when OptProf collection is disabled, avoiding the unavailable-data restore.
  • Gated the MicroBuildOutputs artifact publish on enableOptProf, since it is only produced when the OptProf bootstrapper runs.
  • Moved the MicroBuild/Output staging path into the enableOptProf branch of the artifact-layout check for the same reason.
  • Bumped VersionPrefix to 18.9.15.

Notes

  • Pipeline configuration only; no product code changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e52f6743-7447-4fcb-817f-8f2498b9a5e0
Copilot AI lite review requested due to automatic review settings September 2, 2026 15:02
@AR-May
AR-May requested a review from a team as a code owner September 2, 2026 15:02
@AR-May
AR-May temporarily deployed to copilot-pat-pool September 2, 2026 15:02 — with GitHub Actions Inactive
@AR-May
AR-May temporarily deployed to copilot-pat-pool September 2, 2026 15:02 — with GitHub Actions Inactive
@AR-May
AR-May temporarily deployed to copilot-pat-pool September 2, 2026 15:06 — with GitHub Actions Inactive
@AR-May
AR-May temporarily deployed to copilot-pat-pool September 2, 2026 15:07 — with GitHub Actions Inactive
@AR-May
AR-May temporarily deployed to copilot-pat-pool September 2, 2026 15:07 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The pipeline-only changes are consistent with existing enableOptProf gating patterns in the same templates and align with the stated goal of preventing OptProf-related build failures on this servicing branch.

Pull request overview

Disables OptProf data collection by default on vs18.9 to avoid failures caused by unavailable optimization data / assembly version mismatches during the OptProf collection run, while keeping the existing SkipApplyOptimizationData=true behavior when collection is disabled.

Changes:

  • Set enableOptProf default to false for this branch and document the rationale in the pipeline parameters.
  • Gate publishing of the MicroBuildOutputs artifact on enableOptProf, since it’s only produced when the OptProf bootstrapper runs.
  • Move the MicroBuild/Output staging-path check into the enableOptProf branch of the artifact layout validation; bump VersionPrefix to 18.9.15.
File summaries
File Description
eng/Versions.props Bumps VersionPrefix to 18.9.15 for the servicing branch.
azure-pipelines/.vsts-dotnet-build-jobs.yml Conditions MicroBuildOutputs publication and OptProf-only staging-path validation on enableOptProf.
.vsts-dotnet.yml Defaults enableOptProf to false and documents why OptProf is disabled on this branch.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@AR-May
AR-May marked this pull request as draft September 2, 2026 15:38
@AR-May AR-May self-assigned this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants