Fix TaskAnalyzer path-resolution order and detect inverted compositions - #14972
Draft
ViktorHofer with Copilot wants to merge 3 commits into
Draft
Fix TaskAnalyzer path-resolution order and detect inverted compositions#14972ViktorHofer with Copilot wants to merge 3 commits into
ViktorHofer with Copilot wants to merge 3 commits into
Conversation
Contributor
|
Hello @copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code fix generating inverted composition in TaskAnalyzer
Fix TaskAnalyzer path-resolution order and detect inverted compositions
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item (Internal use):
Summary
MSBuildTask0003 can generate
GetAbsolutePath(Path.GetDirectoryName(path)), which throws for bare filenames. Existing inverted calls also go undiagnosed.GetDirectoryName/GetPathRoot, including nested extractions.Customer Impact
Prevents migration-generated
ArgumentExceptionfor inputs such as"list.xml"and identifies previously accepted inverted calls.Regression?
Existing analyzer/fixer gap, not a runtime regression.
Testing
Regression coverage for both extraction methods, aliases, named arguments, nested calls, nullable inputs, scope, lookalike methods, and Fix All.
Risk
Limited to the unshipped, opt-in analyzer; no runtime changes. The new warning honors existing scope settings. Fixes are withheld where swapping would break
AbsolutePathconsumers or introduce nullable-input warnings.