Skip to content

[Dreaming] Clarify: don't hardcode backslash path separators in test XML - #14973

Merged
AR-May merged 1 commit into
mainfrom
dreaming/hardcoded-path-separators-cb2a79ee735a033a
Sep 8, 2026
Merged

[Dreaming] Clarify: don't hardcode backslash path separators in test XML#14973
AR-May merged 1 commit into
mainfrom
dreaming/hardcoded-path-separators-cb2a79ee735a033a

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What changed

Added one clarifying sentence to .github/instructions/tests.instructions.md, appended to the existing line about NormalizeSlashes/cross-platform path comparisons: a note that item/metadata path values in inline test XML must not hardcode \ as a separator (invalid on Unix) and should be built with Path.Combine instead.

Why

This is a recurring cross-platform correctness miss in test PRs this week:

Both PRs are in the multithreading/path-normalization area and both needed a reviewer to catch a hardcoded-backslash-in-test-XML issue — exactly the kind of miss a short instruction-file note prevents up front.

I checked the existing tests.instructions.md content and confirmed no existing bullet already states this — the nearest related guidance (NormalizeSlashes for cross-platform path comparisons) covers comparison but not construction of test XML path values, so this is a minimal in-place amendment rather than a duplicate.

Reviewers (core MSBuild team)

Suggested reviewers — could not verify individual @dotnet/kitten team membership via the API (404), falling back to team mention: @dotnet/kitten

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by Dreaming (learning atoms curation) · copilot · auto · 53.9 AIC · ⌖ 9.11 AIC · ⊞ 12.3K ·

Recurring cross-platform correctness issue flagged in PR #14916 (bot
review) and PR #14875 (JanProvaznik) — inline test XML metadata values
used hardcoded backslashes, which are invalid path separators on
Unix. Added a clarifying clause near the existing NormalizeSlashes
guidance in tests.instructions.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the Area: Documentation Issues about docs, including errors and areas we should extend (this repo and learn.microsoft.com) label Sep 7, 2026
@github-actions
github-actions Bot requested a review from a team as a code owner September 7, 2026 19:48
@AR-May
AR-May merged commit f12e42e into main Sep 8, 2026
14 checks passed
@AR-May
AR-May deleted the dreaming/hardcoded-path-separators-cb2a79ee735a033a branch September 8, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Documentation Issues about docs, including errors and areas we should extend (this repo and learn.microsoft.com)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant