[Dreaming] Clarify: don't hardcode backslash path separators in test XML - #14973
Merged
Merged
Conversation
Recurring cross-platform correctness issue flagged in PR #14916 (bot review) and PR #14875 (JanProvaznik) — inline test XML metadata values used hardcoded backslashes, which are invalid path separators on Unix. Added a clarifying clause near the existing NormalizeSlashes guidance in tests.instructions.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AR-May
approved these changes
Sep 8, 2026
AR-May
deleted the
dreaming/hardcoded-path-separators-cb2a79ee735a033a
branch
September 8, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added one clarifying sentence to
.github/instructions/tests.instructions.md, appended to the existing line aboutNormalizeSlashes/cross-platform path comparisons: a note that item/metadata path values in inline test XML must not hardcode\as a separator (invalid on Unix) and should be built withPath.Combineinstead.Why
This is a recurring cross-platform correctness miss in test PRs this week:
\in inline test XML metadata (M1='...\sub\file.txt'), which produces invalid paths on Linux/macOS and breaks the intended assertion.Both PRs are in the multithreading/path-normalization area and both needed a reviewer to catch a hardcoded-backslash-in-test-XML issue — exactly the kind of miss a short instruction-file note prevents up front.
I checked the existing
tests.instructions.mdcontent and confirmed no existing bullet already states this — the nearest related guidance (NormalizeSlashes for cross-platform path comparisons) covers comparison but not construction of test XML path values, so this is a minimal in-place amendment rather than a duplicate.Reviewers (core MSBuild team)
Suggested reviewers — could not verify individual
@dotnet/kittenteam membership via the API (404), falling back to team mention:@dotnet/kittenWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.