Skip to content

Added a PHP 8.5 leg to the installer tests. - #3324

Merged
AlexSkrypnyk merged 1 commit into
mainfrom
feature/installer-php85
Nov 14, 2026
Merged

AlexSkrypnyk merged 1 commit into
mainfrom
feature/installer-php85

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Closes #3321

Summary

The vortex-test-installer job in .github/workflows/vortex-test-installer.yml now runs on PHP 8.3, 8.4 and 8.5. The new leg goes through the same steps as the others: composer install, composer normalize --dry-run, composer lint, composer test-coverage, the coverage uploads and the PHAR build and smoke test.

The php-versions matrix stopped at 8.4, so nothing checked that the installer and its locked dependencies run on PHP 8.5. composer.json allows it through php: >=8.3, so a break there would only show up for someone running the installer on 8.5.

After merge, every push and PR to the covered branches runs a 3rd job, vortex-test-installer (8.5), alongside the existing 2. The video generation and the vortex-installer artifact upload stay on the 8.3 leg, and composer.json, the lock file and the installer code are untouched.

Before / After

BEFORE                                   AFTER
┌──────────────────────────────┐         ┌──────────────────────────────┐
│ php-versions: ['8.3', '8.4'] │         │ php-versions:                │
│                              │         │   ['8.3', '8.4', '8.5']      │
├──────────────────────────────┤         ├──────────────────────────────┤
│ vortex-test-installer (8.3)  │         │ vortex-test-installer (8.3)  │
│ vortex-test-installer (8.4)  │         │ vortex-test-installer (8.4)  │
│                              │         │ vortex-test-installer (8.5)  │
├──────────────────────────────┤         ├──────────────────────────────┤
│ video + PHAR artifact: 8.3   │         │ video + PHAR artifact: 8.3   │
└──────────────────────────────┘         └──────────────────────────────┘

Changes

CI (.github/workflows/vortex-test-installer.yml)

  • Added '8.5' to the php-versions matrix. Each leg names its coverage artifact after its version, so the new leg uploads vortex-test-installer-code-coverage-report-8.5 with no clash.

Summary by CodeRabbit

  • Tests
    • Installer tests now run with PHP 8.5, alongside PHP 8.3 and 8.4.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The installer test workflow now includes PHP 8.5 in its version matrix. PHP 8.3 and 8.4 remain included.

Changes: Installer tests

Layer / File(s) Summary
Update PHP test matrix
.github/workflows/vortex-test-installer.yml
The PHP version matrix adds 8.5 and retains 8.3 and 8.4.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · up to 00c15

This change adds PHP 8.5 to the installer test matrix in CI only. It does not change shipped behavior. The new CI job's first run will show whether PHP 8.5 passes, and the change is easy to revert if it does not.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: a PHP 8.5 leg is added to the installer tests. The raw summary and objectives confirm that the PHP 8.5 version was added to the matrix in vortex-test-installer.yml, s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: a PHP 8.5 leg is added to the installer tests. The raw summary and objectives confirm that the PHP 8.5 version was added to the matrix in vortex-test-installer.yml, so the title matches the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 91b965b and 00c15f3.

Files selected for processing: 1

  • .github/workflows/vortex-test-installer.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@github-actions

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6af85a501219042a6c210674--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

This comment has been minimized.

@AlexSkrypnyk
AlexSkrypnyk enabled auto-merge (squash) November 14, 2026 12:57
@AlexSkrypnyk AlexSkrypnyk added the AUTOMERGE Pull request has been approved and set to automerge label Nov 14, 2026
@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.67%. Comparing base (91b965b) to head (00c15f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3324   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         114      114           
  Lines        5077     5077           
  Branches       49       49           
=======================================
  Hits         4705     4705           
  Misses        372      372           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk
AlexSkrypnyk merged commit 67d0657 into main Nov 14, 2026
49 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/installer-php85 branch November 14, 2026 13:18
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1 Board worker 1 AUTOMERGE Pull request has been approved and set to automerge

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

Make installer CI run on PHP 8.5

1 participant