Repository navigation
Added a PHP 8.5 leg to the installer tests. - #3324
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6af85a501219042a6c210674--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 114 114
Lines 5077 5077
Branches 49 49
=======================================
Hits 4705 4705
Misses 372 372 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closes #3321
Summary
The
vortex-test-installerjob in.github/workflows/vortex-test-installer.ymlnow runs on PHP 8.3, 8.4 and 8.5. The new leg goes through the same steps as the others:composer install,composer normalize --dry-run,composer lint,composer test-coverage, the coverage uploads and the PHAR build and smoke test.The
php-versionsmatrix stopped at8.4, so nothing checked that the installer and its locked dependencies run on PHP 8.5.composer.jsonallows it throughphp: >=8.3, so a break there would only show up for someone running the installer on 8.5.After merge, every push and PR to the covered branches runs a 3rd job,
vortex-test-installer (8.5), alongside the existing 2. The video generation and thevortex-installerartifact upload stay on the8.3leg, andcomposer.json, the lock file and the installer code are untouched.Before / After
Changes
CI (
.github/workflows/vortex-test-installer.yml)'8.5'to thephp-versionsmatrix. Each leg names its coverage artifact after its version, so the new leg uploadsvortex-test-installer-code-coverage-report-8.5with no clash.Summary by CodeRabbit