Skip to content

Use dict.items and remove unused variables in tests - #5279

Merged
boegel merged 4 commits into
easybuilders:developfrom
Flamefire:dict-items
Oct 7, 2026
Merged

boegel merged 4 commits into
easybuilders:developfrom
Flamefire:dict-items

Conversation

@Flamefire

Copy link
Copy Markdown
Contributor

This resolves a few warnings generated by PyLint which make the tests a bit simpler/clearer.

E.g. stdout, stderr = self.run_main(args, raise_error=True) is used but then the variables are never used.
When reading this code again it is unclear if this is intentional

Using dict.items is shorter and makes it easier to see what the dict is made of, e.g.:

-                for key in tcs:
-                    tcname = key.split('@')[0]
-                    tcversion, generic_flags, custom_tcopts = tcs[key]  # Could be way below
+                for key, (tcversion, generic_flags, custom_tcopts) in tcs.items():
+                    tcname = key.split('@')[0]

@Flamefire
Flamefire force-pushed the dict-items branch 2 times, most recently from 1c6e3e4 to 9c610ee Compare September 16, 2026 08:45
@Flamefire
Flamefire force-pushed the dict-items branch 2 times, most recently from 790682d to 87c1dc9 Compare October 2, 2026 07:02

@boegel boegel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (5.4.1) milestone Oct 7, 2026
@boegel
boegel merged commit 5ce22ae into easybuilders:develop Oct 7, 2026
41 checks passed
@Flamefire
Flamefire deleted the dict-items branch October 7, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants