Conversation
kdp-cloud
commented
Aug 18, 2026
kdp-cloud
commented
Collaborator
- Fix value rendering in table
- Update Astro to Astro 7.2.2
Collaborator
Author
|
Out of date |
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation site’s schema-rendering pipeline and brings the docs app up to date with Astro 7.2.2, with the intent of improving how schema values are displayed in the generated tables.
Changes:
- Reformat and slightly adjust the bundled ISA JSON schema (notably adding an explicit
"type": "string"toDataTypeEnum). - Add an Astro Content Collections config for a
schemascollection. - Refactor the schema property row component and bump Astro to
^7.2.2in the docs app.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| schemas/isa_json_schema_with_validators.json | Re-indented schema JSON and adds explicit type for DataTypeEnum. |
| docs/src/content.config.ts | Introduces an Astro Content Collection schema for schemas. |
| docs/src/components/SchemaProperty.astro | Small refactor around displaying schema property description (and related values). |
| docs/package.json | Updates Astro dependency to ^7.2.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
3
to
+6
| const propertyType = property.type ?? 'any'; | ||
| const propertyDefaultValue = property.default ?? 'N/A'; | ||
| const propertyTitle = property.title ?? 'Undefined'; | ||
| const propertyDescription = property.description ?? 'N/A'; |
Comment on lines
+11
to
12
| <td class="px-6 py-4 text-center">{propertyDescription}</td> | ||
| <td class="px-6 py-4 text-center">{property.required ? 'Yes' : 'No'}</td> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.