Repository navigation
Keep formatter output stable with comments - #16009
Merged
josevalim merged 1 commit intoOct 20, 2026
Merged
Conversation
Comments attached to the leftmost operand of an operator are now written before the whole expression, function clauses with comments in their arguments start on their own line, and newlines after end of line comments are no longer added inside lists, calls and operators. Closes elixir-lang#16007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16007.
Since #15893, a comment can end up attached to the leftmost operand of an operator (like
aina ++ b), so the formatter printed it in the middle of the expression and moved it again on the next run. This PR:fnand(a, b -> c)clauses on their own line when their arguments have commentsTo check it, I added comments to Elixir's own lib files and formatted them twice: about 20 out of 20k changed on the second run before, none after. Formatting the repo itself doesn't change any file.