Repository navigation
Fix binary backend aggregate axes variable collision - #1864
Merged
josevalim merged 3 commits intoOct 10, 2026
Merged
Conversation
josevalim
approved these changes
Oct 10, 2026
josevalim
reviewed
Oct 10, 2026
Contributor
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found using antigravity.
Problem
In
Nx.BinaryBackend,aggregate_axes/3is designed to expandread_sizewhen reducing along trailing contiguous dimensions so contiguous chunks can be read in one operation.However,
aggregate_read/4had a variable collision in its pattern match:Because axis was bound in the first argument to an integer (the dimension size), [i | axis] required the tail of the axes list to match that same integer. Since the incoming axes argument is a normal list of integers ([i | axes]), this clause never matched and always fell through to the base clause:
defp aggregate_read(shape, _i, _axes, size), do: {shape, size}
Benchmark
For a 500×500 f32 matrix:
• sum along axis 1: 17.2 ms → 3.05 ms (~5.6x faster)
• Memory allocated: 170 KB → 51 KB (~70% reduction)