suppressBrowserRender should either be renamed or updated #42

Activity

1. rwjblue commented on Nov 6, 2017

   

   rwjblue

   on Nov 6, 2017

   Member

   More actions

   cc @rondale-sc
2. rondale-sc commented on Nov 20, 2017

   

   rondale-sc

   on Nov 20, 2017

   Last edited by rondale-sc

   Contributor

   More actions

   @reidab I think maybe that shouldn't be config anymore. Since the consuming application is responsible now for when head-layout component gets rendered I'd expect to have that logic co-located with the component call.

   Something like:

   {{#if fastboot.isFastBoot }}
     {{ head-layout }}
   {{/if}}
   

   If that is the case we need to update the README to remove suppressBrowserRender as an option. And remove any logic around it.

   @rwjblue thoughts?
3. nolman commented on Apr 30, 2018

   

   nolman

   on Apr 30, 2018

   More actions

   Just a heads up - we are using this to dynamically select which CSS gets loaded for our app, when we disable the suppressBrowserRender in fastboot when the app rehydrates the css vanishes as everything in {{head-layout}} gets removed. Not sure what the right name for this variable is but it most likely needs to stay around to prevent triggering a CSS reload.

   👍React with 👍2Reacted by Steve Hull and Jonathan
4. Duder-onomy commented on Dec 12, 2018

   

   Duder-onomy

   on Dec 12, 2018

   More actions

   I have been running into this issue as well.
   Fastboot+Ember renders the head, along with all of its special bits (meta tags, structured data etc)
   Ember comes down the pipe and crushes all of those bits.

   If I do what @rondale-sc suggests (wrap the {{head-layout}} in a {{fastboot.isFastBoot}} check. It fixes my problem.