Skip to content

Log team invitations before responding, not after the email #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ostenbom wants to merge 1 commit into
base: webinar/main
Choose a base branch
from
Open

Log team invitations before responding, not after the email #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions app/(login)/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,17 @@ export const inviteTeamMember = validatedActionWithUser(
})
.returning();

// Email the invitee and log the invite once the response has been sent,
// so inviting feels instant.
const teamId = userWithTeam.teamId;
after(async () => {
await sendInvitationEmail(email, role);
await logActivity(teamId, user.id, ActivityType.INVITE_TEAM_MEMBER);
});
// The activity log is the team's record of what happened, so it is written
// with the invitation and is there as soon as the inviter looks for it.
await logActivity(
userWithTeam.teamId,
user.id,
ActivityType.INVITE_TEAM_MEMBER,
);

// The email provider has a slow tail, so send once the response has gone
// out and inviting still feels instant.
after(() => sendInvitationEmail(email, role));

return { success: "Invitation sent successfully", id: invitation[0].id };
},
Expand Down
Loading