Skip to content

-remove HVX optimization of function SimdAddFeatureDifference. #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ermig1979 merged 1 commit into from
Sep 30, 2026
Merged

-remove HVX optimization of function SimdAddFeatureDifference. #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/2026.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ <h5>Removing</h5>
<li>HVX optimization of function AbsDifference.</li>
<li>HVX optimization of function AbsDifferenceSum.</li>
<li>HVX optimization of function AbsGradientSaturatedSum.</li>
<li>HVX optimization of function AddFeatureDifference.</li>
</ul>

<h4>Python wrapper</h4>
Expand Down
1 change: 0 additions & 1 deletion prj/vs2022/Hvx.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
</Link>
</ItemDefinitionGroup>
<ItemGroup>
<ClCompile Include="..\..\src\Simd\SimdHvxAddFeatureDifference.cpp" />
<ClCompile Include="..\..\src\Simd\SimdHvxBgrToGray.cpp" />
<ClCompile Include="..\..\src\Simd\SimdHvxBgrToRgb.cpp" />
<ClCompile Include="..\..\src\Simd\SimdHvxCpu.cpp" />
Expand Down
3 changes: 0 additions & 3 deletions prj/vs2022/Hvx.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@
<ClCompile Include="..\..\src\Simd\SimdHvxStatistic.cpp">
<Filter>Hvx\Statistics</Filter>
</ClCompile>
<ClCompile Include="..\..\src\Simd\SimdHvxAddFeatureDifference.cpp">
<Filter>Hvx\Motion</Filter>
</ClCompile>
<ClCompile Include="..\..\src\Simd\SimdHvxFill.cpp">
<Filter>Hvx\Image</Filter>
</ClCompile>
Expand Down
4 changes: 0 additions & 4 deletions src/Simd/SimdHvx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ namespace Simd
#ifdef SIMD_HVX_ENABLE
namespace Hvx
{
void AddFeatureDifference(const uint8_t* value, size_t valueStride, size_t width, size_t height,
const uint8_t* lo, size_t loStride, const uint8_t* hi, size_t hiStride,
uint16_t weight, uint8_t* difference, size_t differenceStride);

void BgrToGray(const uint8_t* bgr, size_t width, size_t height, size_t bgrStride,
uint8_t* gray, size_t grayStride);

Expand Down
107 changes: 0 additions & 107 deletions src/Simd/SimdHvxAddFeatureDifference.cpp
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/Simd/SimdLib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,6 @@ SIMD_API void SimdAddFeatureDifference(const uint8_t * value, size_t valueStride
if (Neon::Enable && width >= Neon::A)
Neon::AddFeatureDifference(value, valueStride, width, height, lo, loStride, hi, hiStride, weight, difference, differenceStride);
else
#endif
#ifdef SIMD_HVX_ENABLE
if (Hvx::Enable && width >= Hvx::A)
Hvx::AddFeatureDifference(value, valueStride, width, height, lo, loStride, hi, hiStride, weight, difference, differenceStride);
else
#endif
Base::AddFeatureDifference(value, valueStride, width, height, lo, loStride, hi, hiStride, weight, difference, differenceStride);
}
Expand Down
5 changes: 0 additions & 5 deletions src/Test/TestAddFeatureDifference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ namespace Test
result = result && AddFeatureDifferenceAutoTest(FUNC(Simd::Neon::AddFeatureDifference), FUNC(SimdAddFeatureDifference));
#endif

#ifdef SIMD_HVX_ENABLE
if (Simd::Hvx::Enable && TestHvx(options) && W >= Simd::Hvx::A)
result = result && AddFeatureDifferenceAutoTest(FUNC(Simd::Hvx::AddFeatureDifference), FUNC(SimdAddFeatureDifference));
#endif

return result;
}
}