Repository navigation
data-plane-controller: new task type for testing separate builds - #3481
Merged
Merged
Conversation
mwillman-estuary
approved these changes
Sep 11, 2026
mwillman-estuary
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but I'm no Rust expert. I don't see any logical errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new task type to the executor in automations, adds a configurable option on the DPC to make use of it.
This allows us to run a separate deployment of the data-plane-controller against the task types that have been assigned to this type manually.
Changes the deployment behavior of DPC, no longer deploys either deployment automatically, now requires a manual fire of the workflow.
Workflow steps:
In our internal.tasks table, you can now set something that was previously of
task_type1 totask_type13 and it will run under the other DPC deployment.Documentation links affected:
N/A
Notes for reviewers:
Verified this locally by running 2 copies of DPC against local supabase, one with the dev arg and one without. Confirmed they only operated on their respective task types.