Repository navigation
libkrun based connector VMM sandbox - #3541
Closed
dgreer-dev wants to merge 6 commits into
Closed
dgreer-dev wants to merge 6 commits into
dgreer-dev wants to merge 6 commits into
Conversation
dgreer-dev
force-pushed
the
daveg/libkrun-sandbox
branch
from
September 29, 2026 13:59
4f70834 to
369f2db
Compare
dgreer-dev
force-pushed
the
daveg/libkrun-sandbox
branch
from
September 29, 2026 16:01
369f2db to
d388b8d
Compare
…L alert Cargo builds a package's binaries whenever it builds one of the package's integration tests, so tests/vsock.rs still made nextest put a glibc flow-connector-init in $CARGO_TARGET_DIR/debug even after the test stopped spawning it. locate_bin and $PATH lookups prefer that over the musl build connector containers need, and the Go tests kept failing on GLIBC_2.39. The test is now a Linux-only unit test in the library, which also lets connector-init's tests compile on macOS again. ci:connector-vmm-kvm runs it by name through --lib. vmm_subnets walks the getifaddrs list with `cursor.as_ref()`, which folds the null check into the dereference that CodeQL's rust/access-invalid-pointer flagged. Behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Draft to work out CI things, not ready for review (although always happy for more eyes))
Add the components needed to run a connector inside a libkrun microVM.
The DNS allowlist makes intended destinations reviewable and the VMM enforces the egress policy while it remains intact. Host-side enforcement that would survive a compromised VMM isn't provided by this PR but will be wired up in the operationalizing PR.