Skip to content

fix(theme): preserve transparent terminal backgrounds - #681

Merged
eugenioenko merged 1 commit into
mainfrom
fix/bundled-theme-terminal-transparency
Sep 27, 2026
Merged

eugenioenko merged 1 commit into
mainfrom
fix/bundled-theme-terminal-transparency

Conversation

@eugenioenko

Copy link
Copy Markdown
Owner

Why

Bundled themes that explicitly set terminal.background override the terminal emulator default. When the host terminal uses a transparent background, opening the integrated terminal therefore paints an opaque editor-colored background instead of preserving that transparency.

What changed

  • removed explicit terminal backgrounds from the nine affected bundled themes, matching default-dark
  • retained each theme-specific terminal foreground and ANSI palette
  • added a bundled-theme assertion to prevent explicit terminal backgrounds from returning

Testing

  • go test ./internal/config — proves every embedded theme parses and leaves terminal.background unset
  • make test — full Go and E2E regression suite
  • make lint
  • make build
  • started the built binary with an isolated config directory and completed a scripted --exec session

Screenshot

Not included: text screenshots from the headless --exec screen do not capture host-terminal transparency or background composition.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: eugenioenko/ttt/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7e4e94d2-2a01-452b-88b9-c76d7f4d9f01

📥 Commits

Reviewing files that changed from the base of the PR and between b901ec6 and 0deb2aa.

📒 Files selected for processing (10)
  • internal/config/theme_test.go
  • internal/config/themes/dracula.json
  • internal/config/themes/high-contrast-dark.json
  • internal/config/themes/high-contrast-light.json
  • internal/config/themes/nord.json
  • internal/config/themes/rainy-day-dark.json
  • internal/config/themes/rainy-day.json
  • internal/config/themes/turbo-vision.json
  • internal/config/themes/vscode-dark-plus.json
  • internal/config/themes/zenith.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eugenioenko
eugenioenko merged commit 00aa3bc into main Sep 27, 2026
12 checks passed
@eugenioenko
eugenioenko deleted the fix/bundled-theme-terminal-transparency branch September 27, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant