Skip to content

[In_app _purchase] README excerpt examples and changelog - #12739

Open
gerardomorales88 wants to merge 3 commits into
flutter:mainfrom
gerardomorales88:in_app_purchase-readme-excerpt-examples-and-changelog
Open

[In_app _purchase] README excerpt examples and changelog#12739
gerardomorales88 wants to merge 3 commits into
flutter:mainfrom
gerardomorales88:in_app_purchase-readme-excerpt-examples-and-changelog

Conversation

@gerardomorales88

@gerardomorales88 gerardomorales88 commented Sep 3, 2026

Copy link
Copy Markdown

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Test plan

  • dart run script/tool/bin/flutter_plugin_tools.dart update-excerpts --packages=quick_actions — no diff after regeneration
  • dart run script/tool/bin/flutter_plugin_tools.dart validate --packages=quick_actions — no issues
  • flutter analyze in example/ — no issues
  • dart format --output=none --set-exit-if-changed on the new excerpts file — no changes needed
  • flutter test in the package — all tests pass

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gerardomorales88
gerardomorales88 marked this pull request as ready for review September 3, 2026 16:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the in_app_purchase package's README examples and documentation excerpts to match the current package API, introducing a new readme_examples.dart file to house these code snippets. Feedback on the new file highlights several potential runtime issues, including missing platform guards for iOS/macOS-specific platform additions, a potential out-of-bounds index error when reading transactions, and unsafe null assertions on subscription details for non-subscription products.

Guard StoreKit platform-addition calls with the correct iOS/macOS
platform checks, and avoid unsafe null assertions/index access when
reading Android subscription offers and StoreKit 2 transactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant