[Bug] Commit messages are blank on large repos

[pwalmsley-smtg]

This could be a dupe of #2845 (though that describes themes). My experience is that on a large repo (hundreds of branches, about 100K commits in current branch), the commit messages are often blank, however the SHAs are shown correctly:

Usually scrolling the view down slightly and waiting a few seconds causes it to draw correctly

Version 2.22.0.0, Windows

[DanPristupov]

Thank you for the bug report. Have you noticed what triggers the problem? Does it happen when you scroll down by dragging the scrollbar? Can it happen in a newly opened repo?

[pwalmsley-smtg]

It seems to happen quite reliably when restarting Fork or viewing a repo in a tab for the first time in the session. In one branch of our company repo it takes 6 scroll wheel clicks before it redraws. Dragging the scrollbar also causes it to update. It can happen in newly opened repos too.

One interesting thing is that if I maximise or unmaximise the window then it refreshes the display and they draw OK.

It's easy to reproduce with our company repo, but I can't reproduce with Qt (https://github.com/qt/qtbase) even though it's a similar size (100k commits). Ours has a lot of merges and work on a few major branches at the same time

(this gives an idea of the number of branches and why we need Collapse All Merges turned on:

)

I does seem to happen more often when branch filters are on.

[DanPristupov]

Thank you for the details.

I made a build with the fix.
https://forkapp.ams3.digitaloceanspaces.com/prerelease/Fork-2.22.10.zip

Please extract it somewhere and run fork.exe.

Can you reproduce the problem now?

[pwalmsley-smtg]

Thanks Dan -- that's a great improvement. The commit lines are blank for a couple of seconds when opening the view while it's refreshing, but then it displays OK without needing to touch the mouse

[DanPristupov]

Great!

Now open terminal and run git gc, please.

[pwalmsley-smtg]

After git gc the display is almost instant -- there's about 1s for the initial refresh and draw (which is acceptable on a big repo) but then once a tab has been viewed once, switching to it displays instantly. So I consider this to be fixed. Thanks for the quick response!

[DanPristupov]

Once again, thank you for reporting this bug.
It was a tricky case of events that could only appear in a repository with a massive number of merges and a commit count that wouldn't even fit in memory.
The fix will be a part of the next Fork update.

P.S. Since we are here, if possible, could you please send me Fork benchmark report (Repository -> Benchmark) to support@fork.dev? Those measures would be very helpful for me to understand what needs to be optimized in huge repos.