Repository navigation
Conversation
assumeNotPrecompile only excluded 0x01-0xff, so fuzzers could pick 0x100, the P256VERIFY precompile added in Osaka (EIP-7951).
maurelian
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
October 7, 2026 22:49
maurelian
commented
Oct 7, 2026
| assumeNotPrecompile(addr, getChain("optimism_sepolia").chainId); | ||
| assertTrue( | ||
| addr < address(1) || (addr > address(9) && addr < address(0x4200000000000000000000000000000000000000)) | ||
| addr < address(1) || (addr > address(0x100) && addr < address(0x4200000000000000000000000000000000000000)) |
Author
There was a problem hiding this comment.
This expands the range a lot, but I think it's still reasonable to consider it "within the range of things that might become precompiles". Can change to just add 0x100 instead of expanding, if preferred.
DaniPopes
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assumeNotPrecompileexcludes0x01–0xff, so fuzzers can still pick0x100, the P256VERIFY precompile added in Osaka (EIP-7951). Tests that thenvm.etchthat address fail with "cannot use precompile 0x…0100". We found this running tests on the Amsterdam hardfork.This widens the excluded range to
0x100, updates thetestFuzz_AssumeNotPrecompileassertion, and addstest_AssumeNotPrecompileP256Verify, which uses the existingStdCheatsMockpattern. Both tests fail without the fix.