Repository navigation
Planner: plan a goal for one of a parent's subtasks - #68
Conversation
|
@coderabbitai review |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Goal target selection and saving src/main/java/com/studysync/presentation/ui/components/StudyPlannerPanel.java, src/main/java/com/studysync/presentation/ui/components/TaskListAgenda.java, src/test/java/com/studysync/presentation/ui/components/StudyPlannerPanelTest.java, README.md |
The dialog offers the linked parent and its active subtasks when subtasks exist. It updates the heading and saves the selected task ID. The test covers available targets, selection, and the subtask entry point. TASK_ORDER becomes package-private, and the README describes the target selection. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- geokoko/StudySync#67: PR
#67changes the planner goal dialogs and is the stated stack base for this change. - geokoko/StudySync#66: PR
#66changes planner rules for goals linked to subtasks; this change adds selection of an active subtask when planning from its parent.
Suggested labels: enhancement
Merge Risk: 
Minimal · up to 1733d
-
Goals can be assigned to an active subtask without an identified merge-blocking issue.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
✅ Action performed
|
8f1971b to
1733d3e
Compare
Follow-up to #67, stacked on it: retarget to
masteronce #67 is merged.Plan a subtask's goal from its parent
"Needs a plan" lists a subtask only when the subtask itself is due, scheduled or already planned that day. A course that is weeks late shows up, but its problem sets don't, and planning the course's tile could only add a goal for the course.
Tests
StudyPlannerPanelTest: planning an overdue parent lists its active subtasks (not a completed one) in deadline order and saves the goal to the chosen subtask; a subtask's own tile shows no picker../gradlew checkpasses (247 tests).