Repository navigation
Make make_valid output order deterministic - #1630
Merged
Merged
Conversation
trace_rings iterated a HashSet of boundary edges to pick ring start edges, so ring start vertices and polygon order depended on the per-process RandomState seed. Iterate the edges in spade's order instead, keeping a HashSet only for membership tests. Fixes #1629 Signed-off-by: Claude <noreply@anthropic.com>
urschrei
force-pushed
the
fix_validity_ordering
branch
from
November 2, 2026 21:06
5b21586 to
da51343
Compare
michaelkirk
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trace_rings iterated a HashSet of boundary edges to pick ring start edges, so ring start vertices and polygon order depended on the per-process RandomState seed. Iterate the edges in spade's order instead, keeping a HashSet only for membership tests.
Fixes #1629
If an agent or LLM was involved in this change, please say so below, and note what it was used for. Autonomously-opened pull requests are not accepted: see our policy on agents and LLMs.
CHANGES.mdif knowledge of this change could be valuable to users.