Repository navigation
Conversation
An empty LineString returned AABB::from_corners((MIN, MIN), (MAX, MAX)) as its rstar envelope, so it intersected every envelope query. Polygon delegates to its exterior and MultiPolygon merges member envelopes, so both inherited the problem. Return Envelope::new_empty() instead. Fixes #1638 Signed-off-by: Stephan Hügel <urschrei@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty LineString returned AABB::from_corners((MIN, MIN), (MAX, MAX)) as its rstar envelope, so it intersected every envelope query. Polygon delegates to its exterior and MultiPolygon merges member envelopes, so both inherited the problem. Return Envelope::new_empty() instead.
Fixes #1638
If an agent or LLM was involved in this change, please say so below, and note what it was used for. Autonomously-opened pull requests are not accepted: see our policy on agents and LLMs.
CHANGES.mdif knowledge of this change could be valuable to users.