Decode Relationships.blockingByList under the lexicon's key - #61
Merged
Merged
Conversation
The coding key was `blockingbyList`, so the viewer's own list blocks never decoded from getRelationships. The property keeps its name for source compatibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VoD379fQAwsCNaX4bRsvhq
🦋 Changeset detectedLatest commit: 1408bb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
getRelationshipsresponses never populatedRelationships.blockingbyList. The coding key wasblockingbyList, but theapp.bsky.graph.defs#relationshiplexicon usesblockingByList, so the viewer's own list blocks were always nil. germ-atproto-client's messaging check (checkIf(actor:canStartMessaging:)) relies on that field to refuse messaging when you list-block someone.After: the key decodes and encodes as
blockingByList. The Swift property keeps its current name, so this is a patch release that consumers pick up without source changes.How: the fix is a raw value on the
CodingKeyscase. NewRelationshipsCodingTestscover decode and encode, and both fail without the fix. The changeset is a patch.🤖 Generated with Claude Code
https://claude.ai/code/session_01VoD379fQAwsCNaX4bRsvhq
Generated by Claude Code