Skip to content

Shared plugin filter and sort controls - #3644

Draft
brsbl wants to merge 64 commits into
mainfrom
bb/plugin-controls-thr_c7hh9tvnj3
Draft

brsbl wants to merge 64 commits into
mainfrom
bb/plugin-controls-thr_c7hh9tvnj3

Conversation

@brsbl

@brsbl brsbl commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Plugin collections used inconsistent filters and wrapping toolbars. Icon-only controls gave search excess space, and fixed cutoffs ignored each surface's controls.

What changed

  • Share one grid-width toolbar, ordered Search, Category, Source, Sort, and New plugin where each applies.
  • Keep Category and Source icons beside their labels; combine controls under Filter & sort when space is limited.
  • Show selection counts and directional icons for Name, Published, and Installs; retain Clear footers. Category opens directly to the full list, without a search field.
  • Keep New plugin labeled on mobile; expand cramped search while editing, then restore controls on submit or blur.
  • Rename Installed's Type to Source and User to Direct install; check updates automatically when Installed opens.
  • Match the author-page GitHub icon to the prepared detail layer's filled circular logo.

How you verified

  • Remote CI passed at 7d7dc41312bb27d5d24018ff083080466dfd5176.
  • Headless Chrome for Testing 153.0.8010.36: all five toolbar surfaces align with their grids at 320, 390, and 1440px.
  • Restored Category/Source icons and keyboard opening/dismissal passed at ccd958788.
  • Installed: sort icons and directions, combined summaries, Clear, search expansion/submission, keyboard dismissal, and reload persistence passed.

Browse, Author, and both shelf types passed sort selection/reversal/clearing and whole-query search with exact matching results. Open menus remain stable when selection labels change; toolbar collapse and expansion preserve keyboard focus. Crossing the app shell’s desktop/mobile breakpoint dropped focus in one check; that broader transition remains a follow-up. iOS Safari is unavailable on this Linux host. Native whole-query input was verified; sequential typing retains the previously documented main/dev timing limitation.

Fresh live E2E at 7d7dc4131 used the real dev API (32 installed plugins, 242 catalog entries). Desktop/mobile Installed, Browse, Author, curated shelf and category shelf passed their allowed controls, sort changes/Clear, search matching/empty/clear, and one-row layout. Installed category/source composition and reload persistence also passed. The existing first-open mobile drawer focus failure was reproduced; reopening restores focus. Its shared drawer source is unchanged from the main merge base. No branch-caused failures or source edits were found.

Before: main/merge base 196c1c2dd. After: Layer 3 ccd958788. Same fixtures, routes, light theme, scroll positions, and 2× density. Browse is scrolled to its toolbar.

Surface Before — main After — Layer 3
Installed · 1440×900 Before — Installed · desktop After — Installed · desktop
Installed · 390×844 Before — Installed · mobile After — Installed · mobile
Browse · 1440×900 Before — Browse · desktop After — Browse · desktop
Browse · 390×844 Before — Browse · mobile After — Browse · mobile
Author · 1440×900 Before — Author · desktop After — Author · desktop
Author · 390×844 Before — Author · mobile After — Author · mobile
BB Official shelf · 1440×900 Before — BB Official shelf · desktop After — BB Official shelf · desktop
BB Official shelf · 390×844 Before — BB Official shelf · mobile After — BB Official shelf · mobile
Category shelf · 1440×900 Before — Category shelf · desktop After — Category shelf · desktop
Category shelf · 390×844 Before — Category shelf · mobile After — Category shelf · mobile

Control interactions: desktop 1440×900 and mobile 390×844, at 2×. Before is main 196c1c2dd; after is Layer 3 ccd958788. Source comparisons select BB Community; Sort comparisons use the default order.

State Before — main After — Layer 3
Source menu · desktop Before control source desktop After control source desktop
Source menu · mobile Before control source mobile After control source mobile
Sort menu · desktop Before control sort desktop After control sort desktop
Sort menu · mobile Before control sort mobile After control sort mobile

Additional Layer 3 states. Category captures are from 7d7dc4131; other captures remain at ccd958788. Main Installed has no Category filter, Published sort, combined menu, or expanding search.

Category verification at c2bb5e11a: desktop/mobile full list, initial option focus, Arrow/Home/End navigation, keyboard selection, matching results, and Clear preserving Source/Sort passed. Mobile Back restores focus inside the combined menu. Escape dismisses the mobile drawer but focus returns to the page body; shared drawer focus return remains a follow-up. Desktop Escape restores the trigger.

State Desktop — Layer 3 Mobile — Layer 3
Active selections Layer 3 used active-desktop Layer 3 used combined-mobile
Category selected — no search Layer 3 used category-desktop Layer 3 used category-mobile
Published · newest first Layer 3 used published-desktop Layer 3 used published-mobile
Search focused: Aura Layer 3 used search-desktop Layer 3 used search-mobile

BB-Thread-ID: thr_c7hh9tvnj3

AGENT GENERATED

@brsbl
brsbl added this pull request to stack #3648 September 14, 2026 18:37
Base automatically changed from bb/plugin-cards-thr_c7hh9tvnj3 to main September 17, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant