Conversation
brsbl
added this pull request to stack #3648
September 14, 2026 18:37
…-thr_c7hh9tvnj3 # Conflicts: # apps/app/src/components/plugin/management/PluginBrowseControls.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Plugin collections used inconsistent filters and wrapping toolbars. Icon-only controls gave search excess space, and fixed cutoffs ignored each surface's controls.
What changed
How you verified
7d7dc41312bb27d5d24018ff083080466dfd5176.ccd958788.Browse, Author, and both shelf types passed sort selection/reversal/clearing and whole-query search with exact matching results. Open menus remain stable when selection labels change; toolbar collapse and expansion preserve keyboard focus. Crossing the app shell’s desktop/mobile breakpoint dropped focus in one check; that broader transition remains a follow-up. iOS Safari is unavailable on this Linux host. Native whole-query input was verified; sequential typing retains the previously documented main/dev timing limitation.
Fresh live E2E at
7d7dc4131used the real dev API (32 installed plugins, 242 catalog entries). Desktop/mobile Installed, Browse, Author, curated shelf and category shelf passed their allowed controls, sort changes/Clear, search matching/empty/clear, and one-row layout. Installed category/source composition and reload persistence also passed. The existing first-open mobile drawer focus failure was reproduced; reopening restores focus. Its shared drawer source is unchanged from the main merge base. No branch-caused failures or source edits were found.Before: main/merge base
196c1c2dd. After: Layer 3ccd958788. Same fixtures, routes, light theme, scroll positions, and 2× density. Browse is scrolled to its toolbar.Control interactions: desktop 1440×900 and mobile 390×844, at 2×. Before is main
196c1c2dd; after is Layer 3ccd958788. Source comparisons select BB Community; Sort comparisons use the default order.Additional Layer 3 states. Category captures are from
7d7dc4131; other captures remain atccd958788. Main Installed has no Category filter, Published sort, combined menu, or expanding search.Category verification at
c2bb5e11a: desktop/mobile full list, initial option focus, Arrow/Home/End navigation, keyboard selection, matching results, and Clear preserving Source/Sort passed. Mobile Back restores focus inside the combined menu. Escape dismisses the mobile drawer but focus returns to the page body; shared drawer focus return remains a follow-up. Desktop Escape restores the trigger.BB-Thread-ID: thr_c7hh9tvnj3