Snap outer timeline growth while a thread is active - #3760
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The top-level timeline retained a 180 ms height transition while its thread was active. Bottom anchoring followed the intermediate heights, moving existing rows repeatedly for a single content update. Reproduction and root-cause report.
What changed
Disable outer height growth animation using the timeline's existing active state. Preserve idle easing and existing resize/revision behavior. Three files; 39 changed text lines (37 additions, 2 deletions).
How you verified
height 0ms, receivedheight 180ms.pnpm exec turbo run test --filter=@bb/app -- ThreadTimelineRows height-transition bottom-anchored-scroll-body: 110 tests passed across 15 files after the fix.pnpm exec turbo run typecheck --filter=@bb/app: passed.git diff --check: passed. No binary changes.Fixes #3759